991739 - Links to attachments should not be considered "external"

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Eric Shepherd [:sheppy]]

What did you do?
================
1. Added an attachment to a page.
2. Created a link to that attachment on the page.

What happened?
==============
When viewing the page, the "external" class is applied to the link to the attachment.

What should have happened?
==========================
Attachments are still part of the wiki, despite having a different domain. These should not be considered external, and should not show the little "external" icon next to them.

Is there anything else we should know?
======================================

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6e362c2c6a80a3757d20db877489c2586d4b719b
fix bug 991739 - Dont' show external icon for attachments

https://github.com/mozilla/kuma/commit/d8ad09a917b638a0556474e1f3ed472e61ab21e9
Merge pull request #2248 from darkwing/link-attach-external-991739

fix bug 991739 - Dont' show external icon for attachments

Comment 2

[Les Orchard [:lorchard]]

Hmm, I think we should keep this open for a bit: That CSS tweak works on production, but this bug will still look broken on staging & dev & local VMs

I started looking into how to fix this on the server side, too. Currently, the link annotation filter just checks a single base URL. Instead, it should be able to check a list of base URLs that encompass what's considered an internal link, and those links shouldn't get the "external" CSS class at all.

Comment 3

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.