991741 - Crash in SwapBuffers() because Framebuffer's Fence misuse when HWComposer is not used. [SGS2][JB]

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Juan Gomez [:_AtilA_] (CET/CEST)]

After landing Bug 974152, I'm getting a crash at startup at this point (at least on v1.4):

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 11863.11906]
android::Fence::dup (this=0x0) at frameworks/native/libs/ui/Fence.cpp:99
99          return ::dup(mFenceFd);
(gdb) bt
#0  android::Fence::dup (this=0x0) at frameworks/native/libs/ui/Fence.cpp:99
#1  0x000156bc in mozilla::GonkDisplayJB::SwapBuffers (this=0x4051a300, dpy=0x1, sur=0x4811cb80) at ../../../../gecko/widget/gonk/libdisplay/GonkDisplayJB.cpp:219
#2  0x413269c0 in SwapBuffers (this=0x47d16800) at ../../../gecko/gfx/gl/GLContextProviderEGL.cpp:441
#3  mozilla::gl::GLContextEGL::SwapBuffers (this=0x47d16800) at ../../../gecko/gfx/gl/GLContextProviderEGL.cpp:433
#4  0x413a9c66 in mozilla::layers::CompositorOGL::EndFrame (this=0x482ef860) at ../../../gecko/gfx/layers/opengl/CompositorOGL.cpp:1190
#5  0x41392228 in mozilla::layers::LayerManagerComposite::Render (this=0x47ba2de0) at ../../../gecko/gfx/layers/composite/LayerManagerComposite.cpp:511
#6  0x41392388 in EndTransaction (aFlags=<optimized out>, this=0x47ba2de0, aCallback=<optimized out>, aCallbackData=<optimized out>)
    at ../../../gecko/gfx/layers/composite/LayerManagerComposite.cpp:245
#7  mozilla::layers::LayerManagerComposite::EndTransaction (this=0x47ba2de0, aCallback=0, aCallbackData=<optimized out>, aFlags=<optimized out>)
...

I've found that we are using FrameBufferSurface.cpp::mPrevFBAcquireFence without being correctly initialized when we are not using HWC (SGS2 case).

I already have a patch.

Comment 1

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: 0001-Bug-991741-Crash-in-SwapBuffers-because-Framebuffer-.patch

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8401371 [details] [diff] [review]
0001-Bug-991741-Crash-in-SwapBuffers-because-Framebuffer-.patch

Review of attachment 8401371 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83373340af8d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83373340af8d