Closed Bug 991745 Opened 7 years ago Closed 7 years ago

Change "Search HTML" placeholder text to indicate the search is by CSS Selectors only

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: bgrins, Assigned: gioyik, Mentored)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=835896#c19, the text for the placeholder for the search box in the markup view should be changed, since it isn't searching the HTML.

Maybe: "Search with CSS Selectors"?
Hi,

Can I be assigned this bug please?

Thanks
David
> Can I be assigned this bug please?

Sure, do you have a running Firefox build?  If not, then first follow the instructions here: https://wiki.mozilla.org/DevTools/Hacking.

So basically the code changes needed for this bug are:

* Change the hardcoded string in place from "Search HTML" in inspectorSearchHTML.label here: http://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/inspector.dtd#21.
* Change the name from inspectorSearchHTML.label to inspectorSearchHTML.label2 (this allows localizers to see the change).
* Replace any references to the label entity to the label2 entity: http://dxr.mozilla.org/mozilla-central/search?q=inspectorSearchHTML.label&case=true&redirect=true.
* Test and make sure the string has been updated locally
Assignee: nobody → nelsond5
Mentor: bgrinstead
Status: NEW → ASSIGNED
Hi Brian,

Yeah, I have a running Firefox build. I'll update thread if I have any questions.

Many thanks,
David
Attached patch 991745.patchSplinter Review
Attachment #8554090 - Flags: review?(bgrinstead)
Hi Brian,

I attached a patch for this bug. Can you check it an let me know if it's ok?
Assignee: nelsond5 → gioyik
Comment on attachment 8554090 [details] [diff] [review]
991745.patch

Review of attachment 8554090 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #8554090 - Flags: review?(bgrinstead) → review+
Thank you
https://hg.mozilla.org/mozilla-central/rev/3dd8422c8619
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Great. But can someone explain how to search for (and find) Named Character Reference? Plain Text?

Background:
https://bugzilla.mozilla.org/show_bug.cgi?id=967493
https://bugzilla.mozilla.org/show_bug.cgi?id=835896
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.