991745 - Change "Search HTML" placeholder text to indicate the search is by CSS Selectors only

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Brian Grinstead [:bgrins]]

As noted in https://bugzilla.mozilla.org/show_bug.cgi?id=835896#c19, the text for the placeholder for the search box in the markup view should be changed, since it isn't searching the HTML.

Maybe: "Search with CSS Selectors"?

Comment 1

[David Nelson]

Hi,

Can I be assigned this bug please?

Thanks
David

Comment 2

[Brian Grinstead [:bgrins]]

> Can I be assigned this bug please?

Sure, do you have a running Firefox build?  If not, then first follow the instructions here: https://wiki.mozilla.org/DevTools/Hacking.

So basically the code changes needed for this bug are:

* Change the hardcoded string in place from "Search HTML" in inspectorSearchHTML.label here: http://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/inspector.dtd#21.
* Change the name from inspectorSearchHTML.label to inspectorSearchHTML.label2 (this allows localizers to see the change).
* Replace any references to the label entity to the label2 entity: http://dxr.mozilla.org/mozilla-central/search?q=inspectorSearchHTML.label&case=true&redirect=true.
* Test and make sure the string has been updated locally

Comment 3

[David Nelson]

Hi Brian,

Yeah, I have a running Firefox build. I'll update thread if I have any questions.

Many thanks,
David

Comment 4

[Giovanny Gongora [:gioyik]]

Attachment: 991745.patch

Comment 5

[Giovanny Gongora [:gioyik]]

Hi Brian,

I attached a patch for this bug. Can you check it an let me know if it's ok?

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8554090 [details] [diff] [review]
991745.patch

Review of attachment 8554090 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good

Comment 7

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9db49a2d76c6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/3dd8422c8619

Comment 9

[Giovanny Gongora [:gioyik]]

Thank you

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3dd8422c8619

Comment 11

[Codacoder]

Great. But can someone explain how to search for (and find) Named Character Reference? Plain Text?

Background:
https://bugzilla.mozilla.org/show_bug.cgi?id=967493
https://bugzilla.mozilla.org/show_bug.cgi?id=835896