Closed
Bug 991762
Opened 10 years ago
Closed 10 years ago
functionless inspect button in add-on debugger
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: soeren.hentzschel, Assigned: jsantell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.57 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
In bug 987890 you hid all the unhelpful tools from the add-on debugger, but you forgot one icon: the inspect icon to pick an element. There should be no icon without any function, it does nothing and that is confusing.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jsantell
Assignee | ||
Comment 1•10 years ago
|
||
Waiting on bug 991347 to land so i can add tests to that, otherwise, I have a fix ready
Assignee | ||
Comment 2•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=738a70d249e6
Attachment #8415433 -
Flags: review?(jryans)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8415433 [details] [diff] [review] 991762-hide-picker-tool-addon-dbg.patch Review of attachment 8415433 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8415433 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Wrong try commands, resending to try: https://tbpl.mozilla.org/?tree=Try&rev=b58b1eda4a63
https://hg.mozilla.org/mozilla-central/rev/36d74d4c5c47
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•