991835 - [Messages] Pressing "backspace" in a composer should not remove an attachment without a confirmation

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. open the Messages app, press new message
2. attach something (image or other)
3. input to add some text
4. press backspace to remove the text, and then once more

Expected:
* we have a confirmation dialog before removing the attachment

Actual:
* we have no confirmation dialog

This is happening since 1.1 and this is awkward since 1.1.
Needinfo to Omega for taking advice.

Comment 1

[Omega Feng [:Omega] [:馮於懋]]

IMO a confirmation dialog here might be too strong.
I tried to play with it for a while, and describe the details here:
1) When user attaches an image and types something, it looks like:
 [img]
 hello|
2) Press Backspace 5 times to delete "hello", it looks like:
 [img]
 |
3) Press Backspace 1 more time, the image is deleted:
 |

What we can improve is 2), just move the insert point to the end of line 1 like:
 [img]|
That will improve the experience and feel more like "OK, the next Backspace is deleting the image".

Comment 2

[Julien Wajsberg [:julienw]]

I'll check how we can do what you suggest in comment 1, I don't really remember how it works ;)

Omega, how about that we do a "undo" function ? It's more long-term of course but we could start here? Maybe for another bug?

Comment 3

[Omega Feng [:Omega] [:馮於懋]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Omega, how about that we do a "undo" function ? It's more long-term of
> course but we could start here? Maybe for another bug?

Undo is a good idea if possible. We can use a toast with Undo action like p.6 of the attachment of bug 940365.
Could you file that bug?

Comment 4

[Julien Wajsberg [:julienw]]

Filed Bug 994039 for an undo mechanism.

Here let's focus on the suggestion in comment 1.

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

This is an improvement on UX but won't be a blocker.
Let's put in TopX list.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] julienw:991835-delete-attachment > mozilla-b2g:master

Comment 7

[Julien Wajsberg [:julienw]]

It's not really easy to put the cursor on the previous line, but it's quite easy to add a class. I still need to find when to remove the class though.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] julienw:991835-delete-attachment-3 > mozilla-b2g:master

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8570478 [details] [review]
[gaia] julienw:991835-delete-attachment-3 > mozilla-b2g:master

This is another try that tries to do what Omega proposed. However I stumbled on bug 1137686 while implementing it.

Still this works not bad, because we need 2 "delete" to delete an attachment. But we have no visual cues.

I tested only on Firefox for now, not on device.

Comment 10

[Julien Wajsberg [:julienw]]

And none of the patches work on the device :/ Maybe preventDefault() doesn't work?

Comment 11

[Julien Wajsberg [:julienw]]

I tested a simple patch and preventDefault does work. So something else is happening.

Comment 12

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 13

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(