991905 - [B2G][Camera]Recording videos stutters every second

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

When recording a video, the screen lags every second. The recorded video stutters as well.

Repro Steps:
1) Update a Buri to BuildID: 20140403040201
2) Open the camera app
3) Switch to video mode
4) Record a video

Actual:
The screen hangs every second

Expected:
The screen does not hang at all when recording a video

Master M/C Environmental Variables:
Device: Buri Master M/C MOZ
BuildID: 20140403040201
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 91be2828f17e
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
See attached: video, logcat

Comment 1

[Andrew Stole [:astole]]

The recorded video stutters so badly that, when played back, a user would find it useless.

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.4 with the new camera features work included?

Comment 3

[Hema Koka [:hema]]

Can you check this out please

Comment 4

[Matthew Vaughan]

(In reply to Jason Smith [:jsmith] from comment #2)
> Does this reproduce on 1.4 with the new camera features work included?

This issue does *not* reproduce on the 04/03/14 1.4 build with the new camera features included. The video records smoothly and doesn't seem to have any issues when being played back on the device.

Device: Buri v1.4 MOZ RIL
BuildID: 20140403000210
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Gecko: 5bccd264a0e3
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Curious: if the recorded video is downloaded to a PC, does the playback on the PC also stutter?

Comment 6

[Matthew Vaughan]

TINDERBOX:
- Last Working -
Device: Buri ENG Master v1.5 MOZ RIL
BuildID: 20140401151322
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 4941a2ac0786
Version: 31.0a1
Firmware Version: v1.2-device.cfg

- First Broken -
Device: Buri ENG Master v1.5 MOZ RIL
BuildID: 20140402065726
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 80dcb8e46964
Version: 31.0a1
Firmware Version: v1.2-device.cfg


**This looks to be a gecko issue.**
last working gaia/first broken gecko = REPRO
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 80dcb8e46964

first broken gaia/last working gecko = NO REPRO
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 4941a2ac0786

Push log: http://hg.mozilla.org//mozilla-central/pushloghtml?fromchange=4941a2ac0786&tochange=80dcb8e46964


MOZILLA INBOUND:
- Last Working -
Device: Buri ENG Master v1.5 MOZ RIL
BuildID: 20140401195623
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 9768df843341
Version: 31.0a1
Firmware Version: v1.2-device.cfg

- First Broken -
Device: Buri ENG Master v1.5 MOZ RIL
BuildID: 20140401202523
Gaia: 6274b3645b3d41df4aa5a55398b5d106edf1c528
Gecko: 941bee559cd7
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Push log: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9768df843341&tochange=941bee559cd7


***PLEASE NOTE: Bug 991784 has the same regression window***

Comment 7

[Matthew Vaughan]

Attachment: Sample recorded video while issue occurs.

(In reply to Mike Habicher [:mikeh] from comment #5)
> Curious: if the recorded video is downloaded to a PC, does the playback on
> the PC also stutter?

Yes, the video will stutter during playback after being downloaded to a PC. I have attached a sample video that was recorded while the issue was reproducing.

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Confirmed on hamachi running:
- gecko: b2g-inbound:a4ac15d6912d
- gaia: master:c8e974e69c764b953263c7474d10c25aa68bb862

The video seems to record smoothly for the first few seconds then the video begins to stutter, pausing for a significant amount of time every ~1 second. If the video is played back on the phone, these pauses are visible there too _but_ the recorded audio is continuous and correct.

Also, if the video is played on a PC, the pauses are visible there as well.

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: Logcat with lots of extra camera debugging, filtered to show key events

This logcat shows the smooth stream of buffer dequeueing (i.e. camera driver asks for and gets a buffer) during the preview stream, before starting recording.

After starting recording, we start to get genlock failures. e.g.:

- typically a 100ms timeout when genlock(0x1 /* GENLOCK_UNLOCK */):

04-04 14:20:14.849  1056  1063 I Gecko   : dequeueBuffer: X
04-04 14:20:14.949   145  1224 E libgenlock: perform_lock_unlock_operation: GENLOCK_IOC_DREADLOCK failed (lockType0x0, err=Invalid argument fd=34)

- typically a 1 SECOND timeout when genlock(0x1 /* GENLOCK_WRLOCK */):

04-04 14:20:15.189  1056  1151 I Gecko   : dequeueBuffer: X
04-04 14:20:16.189   145  1224 E libgenlock: perform_lock_unlock_operation: GENLOCK_IOC_DREADLOCK failed (lockType0x1, err=Connection timed out fd=34)

Sotaro, do you know of any recent changes that would cause this issue?

Comment 10

[Sotaro Ikeda [:sotaro]]

It seems a regression of Bug 980647.

Comment 11

[Jason Smith [:jsmith]]

Fixed via backout of bug 980647.

Comment 12

[Brogan Zumwalt [Inactive]]

Issue does not occur on latest Master M-C build

Verifying fixed

Environmental Variables:
Device: Buri Master M-C Mozilla RIL
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg