991966 - js/src/jsfun.cpp:692:9: error: no matching function for call to 'IsAsmJSModule' (--disable-ion)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan Beich]

Attachment: more stubs

In file included from js/src/Unified_cpp_js_src2.cpp:106:
js/src/jsfun.cpp:692:9: error: no matching function for call to
      'IsAsmJSModule'
    if (IsAsmJSModule(fun))
        ^~~~~~~~~~~~~
js/src/jit/AsmJSLink.h:79:1: note: candidate function not viable:
      requires 3 arguments, but 1 was provided
IsAsmJSModule(JSContext *cx, unsigned argc, Value *vp)
^
In file included from js/src/Unified_cpp_js_src2.cpp:106:
js/src/jsfun.cpp:694:9: error: no matching function for call to
      'IsAsmJSFunction'
    if (IsAsmJSFunction(fun))
        ^~~~~~~~~~~~~~~
js/src/jit/AsmJSLink.h:71:1: note: candidate function not viable:
      requires 3 arguments, but 1 was provided
IsAsmJSFunction(JSContext *cx, unsigned argc, Value *vp)
^
In file included from js/src/Unified_cpp_js_src2.cpp:106:
js/src/jsfun.cpp:695:16: error: use of undeclared identifier
      'AsmJSFunctionToString'
        return AsmJSFunctionToString(cx, fun);
               ^
In file included from js/src/Unified_cpp_js_src2.cpp:184:
js/src/jsobj.cpp:4325:19: warning: unused variable 'script'
      [-Wunused-variable]
        JSScript *script = cx->currentScript(&pc);
                  ^
1 warning and 3 errors generated.
gmake[1]: *** [Unified_cpp_js_src2.o] Error 1

http://mozillaproject.osuosl.org:8010/builders/runtests/builds/1223/steps/shell/logs/stdio
http://buildbot.rhaalovely.net/builders/mozilla-central-sparc64/builds/758/steps/build/logs/stdio

Comment 1

[Jan Beich]

Attachment: more stubs

jit/AsmJSModule.h is not even used with JS_ION. It's jsscriptinlines.h that pulls AsmJSLink.h with IsAsmJSFoo declarations.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8401639 [details] [diff] [review]
more stubs

Review of attachment 8401639 [details] [diff] [review]:
-----------------------------------------------------------------

Duh, thanks for doing this!

::: js/src/jit/AsmJSLink.h
@@ +61,5 @@
>      return false;
>  }
>  
> +inline bool
> +IsAsmJSModule(HandleFunction fun)

Could you move this function next to the overloaded variant IsAsmJSModule(JSContext*, unsigned, Value*)?

@@ +67,5 @@
> +    return false;
> +}
> +
> +inline bool
> +IsAsmJSFunction(HandleFunction fun)

And do the same thing for this one, please?

Comment 3

[Jan Beich]

Attachment: more stubs v2

Getting rid of unused |IsAsmJSModuleNative(HandleFunction fun)| in !JS_ION case and re-ordering AsmJSModuleToString to be like its extern counterpart.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8401909 [details] [diff] [review]
more stubs v2

Review of attachment 8401909 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

Comment 5

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59f537a1e9cb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59f537a1e9cb