Closed
Bug 991976
Opened 10 years ago
Closed 10 years ago
"The CLOBBER file has been updated" build-failure message is now printed twice
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: dholbert, Assigned: glandium)
References
Details
Attachments
(2 files)
3.47 KB,
text/plain
|
Details | |
1.30 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Have a non-empty objdir. (and don't have AUTOCLOBBER in your mozconfig) 2. Modify the CLOBBER file 3. run ./mach build ACTUAL RESULTS: The entire chunk of output about "The CLOBBER file has been updated [etc etc]" is printed twice now. EXPECTED RESULTS: This information should only be printed once. I just noticed this for the first time now, and I'm used to seeing this a few times a week, so I suspect this regressed in the past few days or so. My build that reproduces this is at mozilla-central changeset 6c924a018540.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Summary: "The CLOBBER file has been updated" message is now printed twice → "The CLOBBER file has been updated" build-failure message is now printed twice
Assignee | ||
Comment 2•10 years ago
|
||
Interestingly, I can't reproduce.
Assignee | ||
Comment 3•10 years ago
|
||
Scrap that, I can. It doesn't reproduce with mach configure but does with mach build.
Assignee | ||
Comment 4•10 years ago
|
||
I even have it printed three times.
Assignee | ||
Comment 5•10 years ago
|
||
The problem is that mach build calls make -f client.mk, which emits the message when it tries to create .mozconfig.mk (and doesn't). But that error is ignored, so it goes on and calls make -f client.mk realbuild, which emits the message again when it tries to create .mozconfig.mk. But that error is ignored again, so it goes on and calls make -f client.mk configure, which emits the message yet again, but this time, since configure depends on CLOBBER, and that's the rule that fails, it errors out.
Attachment #8401664 -
Flags: review?(mshal)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8401664 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf2c03bddca6
Reporter | ||
Comment 7•10 years ago
|
||
I've confirmed that this is fixed for me on inbound. Thanks!
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cf2c03bddca6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•