992105 - WakeLockListener can unlock screensaver while video is still playing on Windows

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Currently the Windows WakeLockListener locks/unlocks the screensaver based on the last lock/unlock event it received.

Sometimes the WakeLockListener can unlock the screensaver before video playback ends.

STR:
1. Go to http://cd.pn/b2
2. Hit play
3. Fullscreen the video
4. Exit fullscreen
5. Wait for screensaver

Expected:
Screensaver shouldn't appear until after the video finishes.

Actual:
Screensaver can appear while the video is playing.

This is because the WakeLockListener receives an "unlocked" state with topic "DOM_Fullscreen" and thus unlocks the screensaver -- even though the "screen" topic has asked for a "locked" state. The WakeLockListener should store a set of topics that have requested a wake lock and only unlock the screensaver once that set is empty.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Track what topics requested screen wakelock win WinWakeLockListener

Since jimm is away, edwin can you review this. Though you may find this code eerily familiar...

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8402409 [details] [diff] [review]
Patch: Track what topics requested screen wakelock win WinWakeLockListener

Review of attachment 8402409 [details] [diff] [review]:
-----------------------------------------------------------------

Couldn't have done it better myself. ;)

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Landed for gecko 31
https://hg.mozilla.org/integration/mozilla-inbound/rev/a28cd2a8b397

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7de74f07e058 for b2g Win desktop bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=37419071&tree=Mozilla-Inbound

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Needed an #include "nsHashKeys.h". Thank you unified builds.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Landed for gecko 31:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e129328fdfe3

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e129328fdfe3