992129 - [DSDS] Voicemail notification tag does not handle properly multiple SIMs

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

The current voicemail notification tag does not take into account the SIM/voicemail number it is adding a notification for.

STR:
 0. Receive voicemail on SIM1
 1. Receive voicemail on SIM2

Expected:
 We have two notifications

Actual:
 Only once notification is shown

I already have a patch that should be okay, need to add testing.

Comment 1

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/17986

Pleade find attached a link to the github pull request that fixes the issue.

Comment 2

[:gerard-majax]

Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/22300926

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8401894 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/17986

Comments on github, let me know if anything is unclear.

Comment 4

[:gerard-majax]

Fixed a couple of things, and I could test at least on a single SIM device, without any issue.

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8401894 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/17986

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> Fixed a couple of things, and I could test at least on a single SIM device,
> without any issue.

Please flag me for review again when it's the case, otherwise I might miss it.
Will have a look this morning!

Comment 6

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> Fixed a couple of things, and I could test at least on a single SIM device,
> without any issue.

Of course, but after our discussion yesterday, I was waiting to do a real test on a real device, just to be sure.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8401894 [details] [review]
Link to Github https://github.com/mozilla-b2g/gaia/pull/17986

r=me wit the nits addressed (on github)

Comment 8

[:gerard-majax]

(In reply to Etienne Segonzac (:etienne) from comment #7)
> Comment on attachment 8401894 [details] [review]
> Link to Github https://github.com/mozilla-b2g/gaia/pull/17986
> 
> r=me wit the nits addressed (on github)

Thanks. I've addresses the nits, travis is green, but I'm sad, I'm unable to get my hands on a device that we can make work with DSDS and running master.

Comment 9

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/8f158a66eb18071f470ac95f923c75fa8e2edc4a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/aa67c97fc635d4d6a4db0bbf87f6457b43115576

Comment 12

[Eric Chang [:ericcc] [:echang]]

Okay on Fugu v1.4

GAIA_REV=8dff633372022723e2ebad17fe3c826436b3b258
GECKO_REV=574e5ded8f4cd4f4177bbbbfea408e04ae66dddd
GAIA_BRANCH=mozillaorg/v1.4
GECKO_BRANCH=mozillaorg/v1.4
BUILD_TAG=jenkins-B2G.v1.4.0.fugu-23
BuildID=20140414041552