Closed Bug 992214 Opened 7 years ago Closed 7 years ago
Rocketbar title is blank on first boot after FTU
STR: * ROCKETBAR=half make reset-gaia * Go through FTU Expected: * Title says "Search" Actual * Title is blank
Hi Sam, This might be a good first bug on Rocketbar if you're interested?
Thanks I'll take a look
Assignee: nobody → sfoster
The initial content for the Rocket bar's titleContent element is set in the markup. When FTU is skipped this remains as-is and all is good. But when the FTU runs, Rocketbar's listeners for 'applocationchange' and 'apptitlechange' both fire causing the titleContent to get set to ''. When FTU is done, the rocketbar is revealed in this state. I'm looking at Ben's WIP for bug 970935 which adds a listener for 'homescreenopened' and enterHome method which might be of use for resetting the title.
I think this is what we discussed. Tests out ok for me. Not sure if the 'clean' method needs to do more work than it does (updateSearchIndex?) or should be renamed to be more explicit about what it does and does not do. But duplicating code 3 times is my refactor-me threshold :)
Attachment #8404288 - Flags: review?(bfrancis)
Comment on attachment 8404288 [details] [review] Clear the Rocketbar when FTU completes This is great, thanks Sam!
Attachment #8404288 - Flags: review?(bfrancis) → review+
Merged into master https://github.com/mozilla-b2g/gaia/commit/1708fa05690b2ed83a12827d1f14819b994e079f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in before you can comment on or make changes to this bug.