992214 - Rocketbar title is blank on first boot after FTU

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

STR:
* ROCKETBAR=half make reset-gaia
* Go through FTU

Expected:
* Title says "Search"

Actual
* Title is blank

Comment 1

[Ben Francis [:benfrancis]]

Hi Sam,

This might be a good first bug on Rocketbar if you're interested?

Comment 2

[Sam Foster [:sfoster] (he/him)]

Thanks I'll take a look

Comment 3

[Sam Foster [:sfoster] (he/him)]

The initial content for the Rocket bar's titleContent element is set in the markup. When FTU is skipped this remains as-is and all is good. But when the FTU runs, Rocketbar's listeners for 'applocationchange' and 'apptitlechange' both fire causing the titleContent to get set to ''. When FTU is done, the rocketbar is revealed in this state. 

I'm looking at Ben's WIP for bug 970935 which adds a listener for 'homescreenopened' and enterHome method which might be of use for resetting the title.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Clear the Rocketbar when FTU completes

I think this is what we discussed. Tests out ok for me. Not sure if the 'clean' method needs to do more work than it does (updateSearchIndex?) or should be renamed to be more explicit about what it does and does not do. But duplicating code 3 times is my refactor-me threshold :)

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 8404288 [details] [review]
Clear the Rocketbar when FTU completes

This is great, thanks Sam!

Comment 6

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/1708fa05690b2ed83a12827d1f14819b994e079f