Closed Bug 992224 Opened 8 years ago Closed 8 years ago

Minor documentation improvements on the ship-it form

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file, 1 obsolete file)

Various improvement in the release forms: 
* In the input text, show a more recent version of Firefox (bikeshed)
* Fix the declaration. We are using a two columns declaration for Firefox (JSON is for android)
* Add the information about the changeset being tested in TBPL + add URL

The attached patch fixes them.
Attachment #8401873 - Flags: review?(bhearsum)
Comment on attachment 8401873 [details] [diff] [review]
0001-Various-improve-in-the-release-forms.patch

Review of attachment 8401873 [details] [diff] [review]:
-----------------------------------------------------------------

::: kickoff/templates/includes/firefox_release.html
@@ +41,4 @@
>      {% else %}
>          {{ firefoxForm.mozillaRevision(placeholder='abcdef123456')|safe }}
>      {% endif %}
> +    <div class="help">If a relbranch is specified this field is disabled and ignored. The tip of the relbranch will be used instead. It is strongly recommended to select a changeset which has been fully built/tested on the TBPL tool (examples: <a href="https://tbpl.mozilla.org/?tree=Mozilla-Beta">Beta</a>, <a href="https://tbpl.mozilla.org/?tree=Mozilla-Release">Release</a> or <a href="https://tbpl.mozilla.org/?tree=Mozilla-Esr24">ESR24</a>)</div>

Any objection to leaving Esr24 out of this list? I think it'd be good to avoid adding something with a defined end of life like that (because we'll surely forget to update/remove it later, and it'll cause confusion). Looks fine otherwise.
Flags: needinfo?(sledru)
No worries, we can remove it :)
Do you want me to update the patch?
Flags: needinfo?(sledru)
(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> No worries, we can remove it :)
> Do you want me to update the patch?

Yep, please do!
Attachment #8401873 - Flags: review?(bhearsum) → review+
Comment on attachment 8401873 [details] [diff] [review]
0001-Various-improve-in-the-release-forms.patch

Oops, wrong one.
Attachment #8401873 - Flags: review+
Attachment #8401873 - Attachment is obsolete: true
Blocks: 992225
Assignee: nobody → sledru
In production!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.