992224 - Minor documentation improvements on the ship-it form

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Various-improve-in-the-release-forms.patch

Various improvement in the release forms: 
* In the input text, show a more recent version of Firefox (bikeshed)
* Fix the declaration. We are using a two columns declaration for Firefox (JSON is for android)
* Add the information about the changeset being tested in TBPL + add URL

The attached patch fixes them.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 8401873 [details] [diff] [review]
0001-Various-improve-in-the-release-forms.patch

Review of attachment 8401873 [details] [diff] [review]:
-----------------------------------------------------------------

::: kickoff/templates/includes/firefox_release.html
@@ +41,4 @@
>      {% else %}
>          {{ firefoxForm.mozillaRevision(placeholder='abcdef123456')|safe }}
>      {% endif %}
> +    <div class="help">If a relbranch is specified this field is disabled and ignored. The tip of the relbranch will be used instead. It is strongly recommended to select a changeset which has been fully built/tested on the TBPL tool (examples: <a href="https://tbpl.mozilla.org/?tree=Mozilla-Beta">Beta</a>, <a href="https://tbpl.mozilla.org/?tree=Mozilla-Release">Release</a> or <a href="https://tbpl.mozilla.org/?tree=Mozilla-Esr24">ESR24</a>)</div>

Any objection to leaving Esr24 out of this list? I think it'd be good to avoid adding something with a defined end of life like that (because we'll surely forget to update/remove it later, and it'll cause confusion). Looks fine otherwise.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

No worries, we can remove it :)
Do you want me to update the patch?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> No worries, we can remove it :)
> Do you want me to update the patch?

Yep, please do!

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Various-improvement-in-the-release-forms-In-the-inpu.patch

Updated version

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8401873 [details] [diff] [review]
0001-Various-improve-in-the-release-forms.patch

Oops, wrong one.

Comment 6

[[e-mail] (:bhearsum)]

In production!