Closed Bug 992229 Opened 10 years ago Closed 10 years ago

Resizer/titlebar causes panel to jump when used

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(2 files)

Make a panel with a <resizer> or <titlebar> in it. If you try to adjust the position or size, the window jumps down drastically vertically. This is broken on for me on Mac but works fine on Windows.

The issue is that nsMenuPopupFrame::MoveTo takes css pixels but is passed device pixels.
Attached file Testcase
Found this issue while testing the other panel moving bug.
Attachment #8401885 - Flags: review?(tnikkel)
Component: Widget: Cocoa → XP Toolkit/Widgets: XUL
Comment on attachment 8401885 [details] [diff] [review]
titleresizepixels

Well this is obviously wrong.

I look forward to the bugs we find when dev pixels convert to fractional CSS pixels and the rounding to int css pixels causes us problems here. :/ That's already a bug we suffer from though.
Attachment #8401885 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/8513f4c3ad94
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: