992272 - Lock command not working after introduction of Lockscreen Manager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Guilherme Gonçalves [:ggp]]

Bug 937442 introduced the Lockscreen Manager, which broke our lock command.

In the long term, the lockscreen refactor will require a refactoring of the communication between Find My Device and the lockscreen, so that it uses IAC instead of Settings. I'll file a separate bug for that, and use this bug for an immediate fix that leaves the tree in a working state.

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: workaround using mozSettings

This is a bit of a workaround, but should be enough for the purposes of this bug. I filed bug 992277 to look for a long-term solution once the lockscreen refactoring is finished.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8401931 [details] [review]
workaround using mozSettings

Mostly nitpicking on github.

Comment 3

[Guilherme Gonçalves [:ggp]]

Ah, sorry about the style issues. They should be fixed now.

I kept the arrow function, though, as I was just copying a pattern that was already in the existing code. I absolutely don't mind switching if you insist, just pointing out that if it's really a problem, then there are also other places that need fixing.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/17d4bbc13db8b642fbc1ed69a424f92b37cbb78b