99229 - Typo in nsTableFrame.cpp

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Marc Attinasi]

There is an obvious typo that I found when I hit an assertion in one of my
testcases (%height but no width specified on a table). I'd like to just land
this simple change, but I'll request the traditional r and sr...

The offending line is at
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableFrame.cpp#4023

It should be checking position->mHeight, not mWidth

PROPOSED PATCH:

Index: nsTableFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/table/src/nsTableFrame.cpp,v
retrieving revision 3.446
diff -r3.446 nsTableFrame.cpp
4023c4023
<       if (position->mWidth.GetPercentValue() > 0.0f) {
---
>       if (position->mHeight.GetPercentValue() > 0.0f) {

Comment 1

[Chris Waterson]

sr=waterson

Comment 2

[karnaze (gone)]

r=karnaze

Comment 3

[Marc Attinasi]

Fixed on Trunk.

Comment 4

[Chris Petersen]

Marking verified in the Oct 22nd build.