992338 - [B2G][Tarako][Everything.me] The first Bengali keyboard is not working correctly in the everything.me search bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[demerick]

Attachment: logcat.txt

Description:
If the user selects the first Bengali keyboard option and searches via the everything.me search bar, the search is not executed after the user taps return/enter and the string will not be saved in the search history.

The second Bengali keyboard option functions correctly - the search is executed and after exiting and returning to the everything.me search bar the string is in the history.

I have included URLs to videos of both incorrect and correct functionality.

Repro Steps:
1) Update a Tarako to BuildID: 20140403004001
2) Launch 'Settings' from the home screen
3) Tap 'Keyboards' > 'Selected keyboards' > 'Add more keyboards'
4) Tick the check box next to the first Bengali keyboard option and return to the home screen
5) Tap the 'globe' icon in the bottom left corner of the screen
6) Tap at least 3 characters and then tap enter/return in the bottom right of the virtual keyboard
7) Return home
8) Tap the the Everything.me search bar

Actual:
The search is never executed and does not appear in the everything.me search history

Expected:
The search should be executed and the string should be saved in the history

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140403004001
Gaia: 8d212f640014db62c622e8c939ddbf8595f00438
Gecko: ddd7ba612cfe
Version: 28.1
Firmware Version: sp8810

Repro frequency: 100%
See attached: logcat.txt

Video URLS:
1st Keyboard, incorrect functionality: https://www.youtube.com/watch?v=oY6RNAomngU
2nd Keyboard, correct functionality: https://www.youtube.com/watch?v=XzRGFe-b1T8

Comment 1

[demerick]

This issue does not occur on the Buri 1.3 MOZ RIL

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140401004003
Gaia: 24f562fce468fc948ac9e6185e002c23350cb9ee
Gecko: 0adf24a785f2
Version: 28.0
Firmware Version: v1.2-device.cfg

There is no option for the Bengali keyboards on the Buri device.

Comment 2

[Jason Smith [:jsmith]]

The videos here are covering up the bottom of the phone, so it's hard to understand when the home button is being hit. We need the videos here fixed to show the full scope of the phone.

Comment 3

[demerick]

1st Bengali Keyboard Option (Incorrect Functionality): https://www.youtube.com/watch?v=adUVkmV1xlI
2nd Bengali Keyboard Option (Correct Functionality): https://www.youtube.com/watch?v=ib2m-vPlBMA

Comment 4

[Jason Smith [:jsmith]]

Looks like we have a non-functioning keyboard in the mainline build right now. We either need to fix the keyboard here or remove it from the build.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

Bengali keyboard is required. 1.3T+
ni? Luke

Comment 6

[Luke Chang [:lchang] (inactive)]

I think I know how to fix it so take this bug.

Comment 7

[Luke Chang [:lchang] (inactive)]

Hi Steven,
We have two Bengali input methods in B2G which are "Bangla - Avro" and "Bangla - Probhat". Does Tarako need both of these two?

Comment 8

[Steven Yang [:styang]]

Yes, we should support both.

Comment 9

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 18020

Rudy, Could you help to review it? Thanks!

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8402548 [details] [review]
Pull Request 18020

Looks good.

Luke,

Thanks for your help.

--
I think we can land this, but still want to set feedback to the original author to inform him about this change.

Comment 11

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/22427096

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/a0271bcc3c7f05d1fe43b17aee459b6111b6c2e1

Rudy, Thanks!

Comment 12

[ying.xu]

v1.3t
https://github.com/mozilla-b2g/gaia/commit/df1dd90d70f957f2dd34b2f19d1b28a3bd03b974

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fixed on todays 1.3T build.

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140428014001
Gaia: 8895b180ed636069473703d0e7b73086989601ce
Gecko: 7caf4b5abfce
Version: 28.1
Firmware Version: sp6821

The first Bengali keyboard works with everything.me

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

wontfix on v1.4 per bug 1062800 comment 2.