992345 - [B2G][Lockscreen] Lockscreen appears horizontal instead of vertical on landscape

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[pete siphantong [:Petes]]

Attachment: IMG_0080.jpg

Description:
when holding the power button on landscape, the power screen will appear. Press  the power button until the screen is black, press it again and the lockscreen appears horizontal instead of vertical.

Repro Steps:
1) On landscape, go to Gallery
2) Hold the power button, switch between camera and thumbnail view 
3) Press the power button on the power screen
4) Press the power button again


Actual:
On landscape, the lockscreen appears horizontal 

Expected:
On landscape, the lockscreen should appear vertical

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ
BuildID: 20140403000210
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Gecko: 5bccd264a0e3
Version: 30.0a2
Firmware Version: v1.2-device.cfg


keywords:Lockscreen, horizontal, vertical, landscape

Repro frequency: (3/3, 100%)
See attached: (screenshot)

Comment 1

[Jason Smith [:jsmith]]

Does this happen on 1.3?

Comment 2

[Duane Dixon [:ddixon]]

Unable to reproduce issue on latest Buri 1.3 build.

Issue was not reproduced after 10 attempts despite having a 100% repro rate on Buri 1.4

1.3 Environmental Variables:
Device: buri 1.3 MOZ
BuildID: 20140407004003
Gaia: 9555c6d1b40ee40ac0713bba9f54d3943aff635f
Gecko: 4bba1932fb68
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

Can we get a video specifically showing what happens after you unlock the screen in landscape?

Comment 4

[Jason Smith [:jsmith]]

Ok - the video shows evidence here that we're showing the lockscreen in landscape mode in which you cannot unlock the device. You can however, move it back to portrait and be able to unlock the device. So I'd classify this bug as exposing broken UX & a regression.

Comment 5

[Tony Chung [:tchung]]

lockscreen should never be in landscape mode.  blocking 1.4+

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I think the repro step somehow makes the orientation lock failed and we didn't try to re-lock.

:snowmantw, could you resolve this?

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

Handling. May be an one-line fix.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Patch. Will set review after a video and Travis is green.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Solved video:

http://youtu.be/OB9_Bh9WdzE

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Now I'm solving this on v1.4 while I'm waiting Travis.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis is green on master fix:

https://travis-ci.org/mozilla-b2g/gaia/builds/22923936

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8405966 [details] [review]
Patch

Patch on the master branch.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch v1.4

Patch for v1.4.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis is green (v1.4):

https://travis-ci.org/mozilla-b2g/gaia/builds/22932011

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8406003 [details] [review]
Patch v1.4

You need to fill the approval-gaia-v1.4 form.

Comment 16

[Preeti Raghunath(:Preeti)]

Greg,

ni for gaia form to be filled here

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/d50d2f737e179b71a72c687a5329842d562de9f1

I'll handle v1.4 patch later.

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

You should close the bug when it reaches master. and people is still waiting for approval-gaia-v1.4 form.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

[PATCH] Fix the orientation lock in LockScreen when screenchange

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #): seems existing since the v1.4 LockScreen, but I don't know the exact bug

[User impact] if declined: when user open an app in landscape and then lock the screen, because of lacking the corresponding locking code in the event handler, the orientation would not keep in the portrait mode. This affects the LockScreen in v1.4. 

[Testing completed]: Passed all tests on Travis and on real device.

[Risk to taking this patch] (and alternatives if risky): none that I can think of, the change only improve the LockScreen and not change any behavior of it.

[String changes made]: none

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8406003 [details] [review]
Patch v1.4

1.4+ blockers still have auto-approval to land.
https://wiki.mozilla.org/Release_Management/B2G_Landing#Landing_Procedure_5

v1.4: https://github.com/mozilla-b2g/gaia/commit/9cc1b7684c969ed7dd4b8242c56e2fe1d10bc6f3

Comment 21

[Duane Dixon [:ddixon]]

Removing "regression window wanted" as issue is Resolved Fixed.