99245 - Using strtok is evil

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Ulrich Drepper]

Some code in modules/libpref/src still uses strtok.  strtok really must not be
used since it's not thread-safe and not even save to call inbetween sucessive
calls in the same thread.  I'll shortly attach a patch.  The patch also changes
configure.in.  I'll file a few more strtok bugs and some include the same
configure.in change.  So there might be a conflict.

Comment 1

[Ulrich Drepper]

Attachment: Remove uses of strtok

Comment 2

[sairuh (rarely reading bugmail)]

to prefs backend.

Comment 3

[Brian Nesse (gone)]

Not that there appears to be anything wrong with the patch but... The fact that
it only addresses one of the five references to strtok in prefapi.c implies to
me that you are trying to fix a specific bug as opposed to general cleanup. Is
that true?

nsIPref, and therefore NextChild(), is depricated. Changing the calling code to
use nsIPrefService and nsIPrefBranch and using GetChildList() would be
preferable to me. This is not to say, however, that I will stand in the way
landing this patch if there is a good reason for it...

Comment 4

[Ulrich Drepper]

Hum, don't know why the other strtok changes in perfapi are not included. 
Probably I attached the wrong file.  I'll attach an updated, complete patch
(without the configure change which is already in the CVS archive).

And the nsPref.cpp change you cannot leave out until the last user of the code
is gone.

Comment 5

[Ulrich Drepper]

Attachment: updated, complete patch

Comment 6

[Brian Nesse (gone)]

Comment on attachment 49354 [details] [diff] [review]
updated, complete patch

Seems ok to me. r=bnesse.

Comment 7

[Alec Flett]

sr=alecf

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Fix checked into the trunk.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Reopening, since the change to prefapi.c should say |&nextStr| instead of
|nextStr|, and there's also some funky indentation.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

really

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: proposed additional patch

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is attachment 51259 [details] [diff] [review] right?

Comment 13

[Alec Flett]

Comment on attachment 51259 [details] [diff] [review]
proposed additional patch

oops! bad super-reviewer, no cookie... :)
sr=alecf

Comment 14

[Brian Nesse (gone)]

Comment on attachment 51259 [details] [diff] [review]
proposed additional patch

Hmm. oops. r=bnesse.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Revision to fix checked in 2001-09-28 22:55:53 PDT.  Marking FIXED again.

Comment 16

[sairuh (rarely reading bugmail)]

rs vrfy