992469 - Australis bookmarking animation, lightweight theme support

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[alreiten]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140404030202

Steps to reproduce:

Install any darker lightweight theme wherein the color of the bookmark star when the status of the website is bookmarked (bookmark star is filled in) is white.

Random example: https://addons.mozilla.org/en-US/firefox/addon/sakura-bud/

Bookmark a website.


Actual results:

Clicking to bookmark changes the color of the bookmark star to white, but the animation has a blue star.


Expected results:

The animation star color should match the bookmark star color under these conditions.  

Having a white colored bookmark star for these darker themes is great for visibility, but it is visually disconcerting to click on the bookmark star and have it turn white and have a blue star animation going on at the same time.  

The animation color should match the static button color.

Comment 1

[Justin Dolske [:Dolske]]

If we make the star blue with LWTs, then we have to worry about what happens when you've got a blue theme (which would make the star invisible). I don't think this is worth trying to address.

Comment 2

[alreiten]

Justin, I am bit confused.  The Star is already blue as the default.  I believe this was a (fairly) recent change in the development builds.

But if using a darker LWT (including blue) the star is white as a default color on the static button, but blue inside the animation--a mismatch.

Example for blue (white on static, blue in animation): https://addons.mozilla.org/en-US/firefox/addon/blue-white-triangles/ 

I just think that the animation color should match the static color, however it changes under light or dark LWTs.