Closed Bug 992471 Opened 10 years ago Closed 10 years ago

nspr/configure.in should not check for CROSS_COMPILE in the environment

Categories

(NSPR :: NSPR, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
4.10.5

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Ted: This patch reverts the nspr/configure.in change you made
to make targeting the iOS simulator a cross-compile
(bug 676584 comment 1):
https://hg.mozilla.org/projects/nspr/rev/6f66314d62ff

If you don't need this change now, I'd like to revert it.
Mozilla's top-level configure.in and js/src/configure.in
don't check for CROSS_COMPILE in the environment.

Note: because of a recent change to nspr/configure.in, that
if statement has become two if statements.
Attachment #8402153 - Flags: review?(ted)
Comment on attachment 8402153 [details] [diff] [review]
Patch

Review of attachment 8402153 [details] [diff] [review]:
-----------------------------------------------------------------

Mike: could you please review this patch? Thanks.

Try server results: https://tbpl.mozilla.org/?tree=Try&rev=971729142e5f
Attachment #8402153 - Flags: review?(mh+mozilla)
Attachment #8402153 - Flags: review?(mh+mozilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.