Closed
Bug 992471
Opened 10 years ago
Closed 10 years ago
nspr/configure.in should not check for CROSS_COMPILE in the environment
Categories
(NSPR :: NSPR, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
4.10.5
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
1.73 KB,
patch
|
glandium
:
review+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
Ted: This patch reverts the nspr/configure.in change you made to make targeting the iOS simulator a cross-compile (bug 676584 comment 1): https://hg.mozilla.org/projects/nspr/rev/6f66314d62ff If you don't need this change now, I'd like to revert it. Mozilla's top-level configure.in and js/src/configure.in don't check for CROSS_COMPILE in the environment. Note: because of a recent change to nspr/configure.in, that if statement has become two if statements.
Attachment #8402153 -
Flags: review?(ted)
Assignee | ||
Comment 1•10 years ago
|
||
Comment on attachment 8402153 [details] [diff] [review] Patch Review of attachment 8402153 [details] [diff] [review]: ----------------------------------------------------------------- Mike: could you please review this patch? Thanks. Try server results: https://tbpl.mozilla.org/?tree=Try&rev=971729142e5f
Attachment #8402153 -
Flags: review?(mh+mozilla)
Updated•10 years ago
|
Attachment #8402153 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8402153 [details] [diff] [review] Patch Patch checked in: https://hg.mozilla.org/projects/nspr/rev/9accf627e294
Attachment #8402153 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8402153 [details] [diff] [review] Patch Patch pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a49b88c5bb0
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3a49b88c5bb0
Updated•10 years ago
|
Attachment #8402153 -
Flags: review?(ted)
You need to log in
before you can comment on or make changes to this bug.
Description
•