992593 - Remove File->Page setup on BSDs and Solaris, too

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Jan Beich]

Attachment: fix

Menu is specific to toolkit, not OS. However, only Linux, and by extenion other Unices, support more than one toolkit. Thus we're partly going back on bug 842913 to avoid forking default theme for XP_UNIX && !XP_LINUX && !XP_MACOSX.

-DXP_LINUX idea to avoid churn was rejected in bug 948946 comment 9.

Comment 1

[Jan Beich]

Attachment: screenshot

Like on Linux, Page setup is still there in Print dialog.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8402235 [details] [diff] [review]
fix

I'm not confident this syntax works with the XUL preprocessor. Did you test that this doesn't remove the menuitem on Windows/Mac?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8402235 [details] [diff] [review]
fix

Reviewing the preprocessor docs/test, I'm pretty sure this doesn't work.

Comment 4

[Jan Beich]

python/mozbuild/mozbuild/preprocessor.py tries to mimic cpp-like syntax, see the description in the file. For one, removing -DMOZ_WIDGET_GTK from ACDEFINES in obj-*/config/autoconf.mk brings back menu_printSetup in dist/bin/**/browser.xul.

I don't have Try access to feed QA test builds. Not to mention QA'd probably already noticed if attachment 8347190 [details] [diff] [review] didn't work as expected. And linux firefox-29.0b5 from ftp.m.o also works as I expect it to.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8402235 [details] [diff] [review]
fix

OK, sorry about that - I was wrong.

Comment 6

[Jan Beich]

bug 992621 adds more examples of accepted syntax

Comment 7

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/fd2ba49e9abb

Thanks for the patch

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/fd2ba49e9abb