Closed
Bug 992621
Opened 12 years ago
Closed 12 years ago
test complex ifdefs in preprocessor
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: jbeich, Assigned: jbeich)
Details
Attachments
(1 file, 1 obsolete file)
|
2.98 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
I've got a patch rejected in bug 992593 comment 3 due to a confusion about preprocessor syntax. It seems the description and available tests are not enough to infer which cpp-like constructs work.
// works
#if !defined(FOO) && !defined(BAR)
// broken
#if !defined FOO && !defined BAR
Attachment #8402266 -
Flags: review?(gps)
slightly better test names
Attachment #8402266 -
Attachment is obsolete: true
Attachment #8402266 -
Flags: review?(gps)
Attachment #8402275 -
Flags: review?(gps)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8402275 [details] [diff] [review]
v0.1
Review of attachment 8402275 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Thanks for contributing tests!
Attachment #8402275 -
Flags: review?(gps) → review+
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•