Closed
Bug 992634
Opened 11 years ago
Closed 10 years ago
Build fails for flatfish in GonkGPSGeolocationProvider.cpp
Categories
(Core :: DOM: Geolocation, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: gerard-majax, Assigned: gerard-majax)
Details
(Keywords: regression)
Attachments
(1 file)
|
558 bytes,
patch
|
dougt
:
review-
|
Details | Diff | Splinter Review |
Looks like the work for adding MLS and stuff like that does not completely encapsulate out MOZ_B2G_RIL, and hence build for Flatfish (which has no MOZ_B2G_RIL defined) fails because of lacking nsIRilNetworkInterface.
Attached is a quick patch that at least makes the build pass. I did not tested it a lot.
Attachment #8402285 -
Flags: review?(dougt)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → lissyx+mozillians
|
||
Comment 1•11 years ago
|
||
instead we should remove the nsIObserver implementation on non MOZ_B2G_RIL defined builds. I looks like Observe() is only used for MOZ_B2G_RIL things.
|
|
||
Updated•10 years ago
|
Attachment #8402285 -
Flags: review?(dougt) → review-
|
|
Assignee | |
Comment 2•10 years ago
|
||
This has been somehow fixed.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•