Closed Bug 992643 Opened 6 years ago Closed 6 years ago

Options... and some others should not end w/ ellipsis.

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 31.0

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch bugXXX_rem_ellipsis.patch (obsolete) — Splinter Review
We removed some of the wrong ellipsis in bug 956481, but some remains. E.g. Options... which firefox fixed back in bug 610922.

This patch fixes the most obvious ones. I think the Search X... ones are up for discussion.
Also found an unused proxy.label+accesskey.
Attachment #8402292 - Flags: ui-review?(squibblyflabbetydoo)
Attachment #8402292 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8402292 [details] [diff] [review]
bugXXX_rem_ellipsis.patch

Review of attachment 8402292 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like the right thing to do, but it seems like you missed some string changes...

::: mail/base/content/mailWindowOverlay.xul
@@ +2969,5 @@
>  #ifdef XP_MACOSX
>          <menuseparator id="prefSep"/>
> +        <menuitem id="menu_accountmgr" label="&accountManagerCmd2.label;" accesskey="&accountManagerCmd2.accesskey;" oncommand="MsgAccountManager(null);"/>
> +        <menuitem id="menu_preferences"
> +                  label="&preferencesCmdMac.label;"

Should this be `&preferencesCmdMac2.label;`?

::: mail/locales/en-US/chrome/messenger/addressbook/abMainWindow.dtd
@@ +121,5 @@
>  <!ENTITY importCmd.label                                "Import…">
>  <!ENTITY importCmd.accesskey                            "I">
>  <!ENTITY exportCmd.label                                "Export…">
>  <!ENTITY exportCmd.accesskey                            "E">
> +<!ENTITY preferencesCmd2.label                           "Options…">

Did you mean to change this string? (Also this string got indented one extra character...)

::: mail/locales/en-US/chrome/messenger/messenger.dtd
@@ +477,5 @@
>  <!ENTITY errorConsoleCmd.accesskey "E">
>  <!ENTITY errorConsoleCmd.commandkey "j">
>  <!ENTITY clearRecentHistory.label "Clear Recent History…">
>  <!ENTITY clearRecentHistory.accesskey "H">
> +<!ENTITY accountManagerCmd2.label "Account Settings…">

Ditto here.

::: mail/locales/en-US/chrome/messenger/messengercompose/messengercompose.dtd
@@ +179,5 @@
>  <!ENTITY messengerCmd.commandkey "1">
>  <!ENTITY addressBookCmd.label "Address Book">
>  <!ENTITY addressBookCmd.accesskey "a">
>  <!ENTITY addressBookCmd.key "B">
> +<!ENTITY accountManagerCmd2.label "Account Settings…">

Ditto here.

@@ +182,5 @@
>  <!ENTITY addressBookCmd.key "B">
> +<!ENTITY accountManagerCmd2.label "Account Settings…">
> +<!ENTITY accountManagerCmd2.accesskey "S">
> +<!ENTITY accountManagerCmdUnix2.accesskey "S">
> +<!ENTITY preferencesCmd2.label "Options…">

Ditto here.
Attachment #8402292 - Flags: ui-review?(squibblyflabbetydoo)
Attachment #8402292 - Flags: ui-review+
Attachment #8402292 - Flags: review?(squibblyflabbetydoo)
Attachment #8402292 - Flags: review-
Attached patch proposed fix, v2Splinter Review
Oops, seems I did qrefresh, but forgot to export the latest :/
One of the things you noticed was real though, so I fixed that (and lined up some attrs i change)
Attachment #8402292 - Attachment is obsolete: true
Attachment #8402841 - Flags: ui-review+
Attachment #8402841 - Flags: review?(squibblyflabbetydoo)
s/menu_accountManager/menu_accountmgr (for the menu that was missing an id)
Comment on attachment 8402841 [details] [diff] [review]
proposed fix, v2

Review of attachment 8402841 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! (Note that I didn't actually compile with this patch.)
Attachment #8402841 - Flags: review?(squibblyflabbetydoo) → review+
https://hg.mozilla.org/comm-central/rev/188e288501f2 (leaving open as i found a couple of other places we should fix)
Target Milestone: --- → Thunderbird 31.0
Part 2, fixing
 - addressbook Properties... 
 - folder context settings + properties
 - Offline Settings
Attachment #8406304 - Flags: ui-review?(squibblyflabbetydoo)
Attachment #8406304 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8406304 [details] [diff] [review]
proposed fix, part2

Review of attachment 8406304 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! rs=me
Attachment #8406304 - Flags: ui-review?(squibblyflabbetydoo)
Attachment #8406304 - Flags: ui-review+
Attachment #8406304 - Flags: review?(squibblyflabbetydoo)
Attachment #8406304 - Flags: review+
Part2 landed - https://hg.mozilla.org/comm-central/rev/b940fa424367 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.