992731 - Stop SVGPathElement.getTotalLength from returning NaN

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open http://cmx.io/edit/sample.html

Actual Results:
a single green line is drawn

And an error shown:
Error: TypeError: Argument 1 of SVGPathElement.getPointAtLength is not a finite floating-point value.
Source File: http://cmx.io/v/0.1/cmx.js
Line: 22654

Expected Results:
Cartoon should be drawn


http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2c4c218a7a09&tochange=f853e8ff85ea

Regressed by:
f853e8ff85ea	Bas Schouten — Bug 987077: Correctly deal with a constant acceleration. r=jwatt

Comment 1

[Benjamin Kerensa [:bkerensa]]

Bas, Can you have a look at this?

Comment 2

[Bas Schouten (:bas.schouten)]

jwatt, can you come up with a minimal testcase for me?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Jonathan, could you have a look here? I can still reproduce it with today aurora. Thanks

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: reduced testcase

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: very reduced testcase

Comment 6

[Daniel Holbert [:dholbert]]

(I can reproduce in 64-bit Linux nightly builds. OS-->All, version-->Trunk)

Comment 7

[Bas Schouten (:bas.schouten)]

Attachment: Correctly treat a straight line as one infinite inflection point.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

This kind of thing should really have a test case when it's checked in.

Comment 9

[Bas Schouten (:bas.schouten)]

I have a testcase in my queue on the Moz2D repo, to land once I do a merge from m-c to moz2d.

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9f56d8be7e42

Comment 11

[Paul Silaghi, QA [:pauly]]

Attachment: chrome vs nightly.png

There several differences comparing the drawings in chrome vs nightly 32.0a1 (2014-06-02). Also the values returned by the reduced testcases are different.
Does it actually matter?

Comment 12

[Daniel Holbert [:dholbert]]

Thanks, Paul -- I see the same results (much too tiny box around "One Lazy Morning" in Nightly).  Firefox release version matches Chrome, with a normal-sized border-box.

Probably best to track that in a separate bug, though. Mind filing?

Comment 13

[Paul Silaghi, QA [:pauly]]

Done - bug 1020255

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Bas, can we get an uplift request for 31? Thanks.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Too late for 31.
Untracking it.