Closed Bug 992887 Opened 6 years ago Closed 6 years ago

Rename mach jittest to mach check-spidermonkey and add jstest support

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file, 1 obsolete file)

With the planned removal of 'make check' it would be good to have a standard way for contributors to run all of the test suites relevant to spidermonkey. 

Bug 988849 added support for jit-tests. This should be expanded to run the jstest suite and be renamed to check-spidermonkey.
Summary: Rename mach jittest to mach check-spidermonkey and jstest support → Rename mach jittest to mach check-spidermonkey and add jstest support
I've renamed this to check-spidermonkey and added the jstests.

I removed the tinderbox formatted output, I think it is easier for people to read with the progress indication and summary at the end.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Attachment #8404085 - Flags: feedback?(terrence)
Comment on attachment 8404085 [details] [diff] [review]
Add check-spidermonkey command to mach

Review of attachment 8404085 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Please also add jsapi-tests and check-style.
Attachment #8404085 - Flags: feedback?(terrence) → feedback+
Added jsapi-tests and check-style.
Attachment #8404085 - Attachment is obsolete: true
Attachment #8404691 - Flags: review?(gps)
Comment on attachment 8404691 [details] [diff] [review]
Add check-spidermonkey command to mach

Review of attachment 8404691 [details] [diff] [review]:
-----------------------------------------------------------------

I'm out of commission for a while. Reassigning review.
Attachment #8404691 - Flags: review?(gps) → review?(mshal)
Comment on attachment 8404691 [details] [diff] [review]
Add check-spidermonkey command to mach

>+    'check-spidermonkey': {
>+        'aliases': ('Sm', 'sm'),
>+        'mach_command': 'check_spidermonkey',

This needs to be 'check-spidermonkey' to match the mach command (dash, not underscore).

>         if params['valgrind']:

When I run './mach test sm', I get:

KeyError: u'valgrind'

  File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 143, in test
    status = self._run_test(entry)
  File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 163, in _run_test
    suite['mach_command'], self._mach_context, **suite['kwargs'])
  File "/home/marf/mozilla-central-git/python/mach/mach/registrar.py", line 62, in dispatch
    return fn(**args) or 0
  File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 236, in run_checkspidermonkey
    if params['valgrind']:

Maybe we want:

if 'valgrind' in params:

?
Attachment #8404691 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #5)
> 
> KeyError: u'valgrind'
> 
>   File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 143,
> in test
>     status = self._run_test(entry)
>   File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 163,
> in _run_test
>     suite['mach_command'], self._mach_context, **suite['kwargs'])
>   File "/home/marf/mozilla-central-git/python/mach/mach/registrar.py", line
> 62, in dispatch
>     return fn(**args) or 0
>   File "/home/marf/mozilla-central-git/testing/mach_commands.py", line 236,
> in run_checkspidermonkey
>     if params['valgrind']:
> 
> Maybe we want:
> 
> if 'valgrind' in params:
> 
> ?
Thanks for catching that! It looks like I need to provide a default value for valgrind in the alias: 
    'check-spidermonkey': {
        'aliases': ('Sm', 'sm'),
        'mach_command': 'check-spidermonkey',
        'kwargs': {'valgrind': False},
    },
https://hg.mozilla.org/mozilla-central/rev/9e05b74b44a7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.