992975 - Partner repack changes for web.de, gmx, and mail.com (Firefox 29)

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Diff of changes for Firefox 29

Comment 1

[Mike Kaply [:mkaply]]

Comment on attachment 8402719 [details] [diff] [review]
Diff of changes for Firefox 29

This patch looks worse than it is.

Most of the changes were:

Australis.
Code refactoring to remove hardcoded paths.

Please let me know if you have questions.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8402719 [details] [diff] [review]
Diff of changes for Firefox 29

Review of attachment 8402719 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for getting this in so early :)

Comment 3

[Mike Kaply [:mkaply]]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> Thanks for getting this in so early :)

Happy to do it. This is not completely signed off by the test team, so there is a small chance of fixes.

Also, this doesn't have the final version in it (It's marked rc) because we wanted to wait for test signoff to do that.

We figured get it in as early as possible.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Final patch based on testing

This is our final patch based on testing.

It has three changes:

1. Change URL of our error reporting server.
2. Change one of the parameters we use for reporting.
3. Bump version to final.

Once this is in, we'll be done for FF29

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8403290 [details] [diff] [review]
Final patch based on testing

Review of attachment 8403290 [details] [diff] [review]:
-----------------------------------------------------------------

rubberstamp+

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Final final patch based on testing and AMO

Our test found an issue where we didn't prefix a pref and AMO found the same.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 8408959 [details] [diff] [review]
Final final patch based on testing and AMO

Review of attachment 8408959 [details] [diff] [review]:
-----------------------------------------------------------------

Mike, I think we said that you should be looking at these now?

Comment 8

[Mike Kaply [:mkaply]]

This shipped.