Open Bug 993017 Opened 6 years ago Updated 4 years ago
Flashing when opening menulist in add-ons settings
STR: 1) Install this add-on: http://people.mozilla.org/~mleibovic/worldcupfeed.xpi 2) Go to add-on detail page in add-on manager 3) Select Country menulist 4) Notice ugly flashing The code for this is here: https://github.com/leibovic/world-cup-feed/blob/master/content/options.xul https://github.com/leibovic/world-cup-feed/blob/master/bootstrap.js#L165 wesj, any ideas?
Weird. It looks like we quickly show the menupopup. I think this is a recent regression. We don't really support multiple windows on Android, so I'm surprised. We intercept clicks on menulists, and show a native dialog based on the contents of the menupopup. Neil, do you happen to know if something changed recently that would tickle this?
Flags: needinfo?(wjohnston) → needinfo?(enndeakin)
I noticed this testing on aurora, but I haven't tested beta/release.
(In reply to Wesley Johnston (:wesj) from comment #1) > We intercept clicks on menulists, and show a native dialog based > on the contents of the menupopup. Where does this happen?
The handleEvent is here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/SelectHelper.js#9 The actual event is registered in our browser.js for some reason: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#4544
I don't see anything that would be caused by menus/menulists, so something in the mobile code.
Device: LG Nexus 4 OS: Android 4.4.2 Builds: 1.Nightly 29.0a1 (2014-02-03)- The message appears "World Cup could not be installed because it is not compatible with Nightly 29.0a1" 2.Nightly 30.0a1 (2014-02-04)- affected; flashing occurs while tapping the menulist, even if the country options are not implemented.
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 30+
(In reply to Teodora Vermesan (:TeoVermesan) from comment #6) > Device: LG Nexus 4 > OS: Android 4.4.2 > Builds: > 1.Nightly 29.0a1 (2014-02-03)- The message appears "World Cup could not be > installed because it is not compatible with Nightly 29.0a1" > 2.Nightly 30.0a1 (2014-02-04)- affected; flashing occurs while tapping the > menulist, even if the country options are not implemented. I made a test add-on that's compatible with release, and I'm seeing this issue even on release (28), so it's not a regression.
On latest Nightly (2014-04-15) I don't see the flashing when opening the menulist in add-ons settings.
(In reply to Teodora Vermesan (:TeoVermesan) from comment #8) > On latest Nightly (2014-04-15) I don't see the flashing when opening the > menulist in add-ons settings. Did you re-install the add-on? If so, that's because the add-on changed.
Yes, I re-installed it and it was a clean profile.
I made an add-on to help test these options: https://github.com/leibovic/options-kitchen-sink You can install the add-on from here: http://people.mozilla.org/~mleibovic/optionskitchensink.xpi
This isn't important for Fx30 anymore, since I updated my add-on to use a select instead of a menulist as a workaround. However, if you install my kitchen sink add-on, then try panning on the add-ons options page after tapping on the menulist, you can see even more flashing. Brad, I showed this to you yesterday, any idea who might be good to look into this?
Assignee: margaret.leibovic → nobody
tracking-fennec: 30+ → ?
Component: Add-on Manager → Graphics, Panning and Zooming
snorp, this looked like bad composition to me, can you have a look?
Assignee: nobody → snorp
Being able to reproduce this on Alcatel One Touch(Android 4.1) on 29 Beta 10 using Tap Translate add-on.
Still reproducible on latest Nightly 05/28 on Alcatel One Touch (Android 4.1) using Tap Translate add-on
filter on [mass-p5]
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.