993047 - Support outerizing and addProperty hooks on globals with WebIDL bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8402813 [details] [diff] [review]
v1

Review of attachment 8402813 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +1941,5 @@
>  }
>  
> +/* static */
> +JSObject*
> +nsGlobalWindow::OuterObject(JSContext* aCx, JS::HandleObject aObj)

JS::Handle<JSObject*>, please (also in the header)

@@ +1943,5 @@
> +/* static */
> +JSObject*
> +nsGlobalWindow::OuterObject(JSContext* aCx, JS::HandleObject aObj)
> +{
> +  nsGlobalWindow *origWin;

Stars to the left, please

@@ +1953,5 @@
> +    // running on a window w/o an outer, which means this hook should
> +    // never be called when we have no outer. But just in case, return
> +    // null to prevent leaking an inner window to code in a different
> +    // window.
> +    NS_WARNING("nsGlobalWindow::OuterObject shouldn't fail!");

Perhaps this should say more about the reason it did fail.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8402813 [details] [diff] [review]
v1

>+            (not desc.workers or
>+             not desc.interface.getExtendedAttribute("Global")))

So this is really saying "not a worker global", right?  Does it make sense to write that as:

            not (desc.workers and desc.interface.getExtendedAttribute("Global")))

?

r=me with that

Comment 3

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6b0e518f6d2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6b0e518f6d2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7513571f8c0e