993070 - [B2G][Camera] Self Timer Settings are saved inconsistently when changing them in camera share activity

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Logcat

Description:
When the user changes the camera settings by accessing the camera from apps such as wallpaper, messages, video, etc, the settings will be saved inconsistently. The self timer setting changes will be saved when going in and out of the camera app itself, but will not be saved when changing the setting through a share activity. The grid line setting changes are always saved

Repro Steps:
1) Update a Buri to BuildID: 20140407000203
2) Launch the camera app through another app such as wallpaper
3) Turn the grid lines and any of the self timers on
4) Go to the home screen and launch directly into the camera app
5) Check the settings in the camera app

Actual:
Grid lines will stay on, but Self-Timer will be off

Expected:
Both settings either stay on, or are reset to be off

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140407000203
Gaia: 86de7fcce674ef6196d68e7e23552d219a3d72db
Gecko: 6e028297be14
Version: 30.0a2
Firmware Version: v1.2-device.cfg


Keywords: Grid, Line, Self, Timer, Share


Repro frequency: 100%
See attached: Logcat

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attaching Video via youtube


This issue does not occur on the 3/26 buri v 1.4 Moz RIL or the Buri v 1.3 Mozilla RIL

3/26 1.4 Environmental Variables
Device: Buri v 1.4.0 Mozilla RIL
Build ID: 20140326000201
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/4889124accfa
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Platform Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.3 Environmental Variables:
Device: Buri v 1.3 Mozilla RIL
BuildID: 20140401164001
Gaia: c5cd3a11e91339163b351d50769eaca0067da860
Gecko: 5045a67b47ed
Version: 28.0
Firmware Version: v1.2-device.cfg

Camera settings is a new feature

Comment 2

[Jason Smith [:jsmith]]

The settings are supposed to persist here, right? Or do we do things differently when someone is picking a picture vs. opening up the camera app & taking a picture?

Comment 3

[Hema Koka [:hema]]

Flash, Video/Pic Size, Grid, and HDR are persisted...but not self-timer with the current implementation

Comment 4

[Jason Smith [:jsmith]]

(In reply to Hema Koka [:hema] from comment #3)
> Flash, Video/Pic Size, Grid, and HDR are persisted...but not self-timer with
> the current implementation

Hmm. So it's expected that the current implementation of the self-timer should not persist settings. So we're doing the right behavior here, but...

The UX here is confusing. The options menu includes an item that persists over use & an item that doesn't persist over use, so how does a user know right now which option they've set should or shouldn't retain it's state after the camera app is killed & relaunched? We need to somehow clarify in the UX here that "this data persists over multiple camera uses" vs. "this data won't persist over multiple camera uses."

Over to UX to see what they think.

Comment 5

[Tiffanie Shakespeare [:tif]]

So I just flashed our camera master branch and I'm getting totally different results...

Open camera, toggle to video and turn off HDR, Grid Lines, and Self-Timer.

Launch messaging app, tap paper clip, and select camera. 

Camera launches to photo mode. I enable HDR, Grid Lines, and Self-Timer. I take a photo.

Return to Camera app. I am still in video mode and nothing is enabled. I toggle to photo mode and nothing is enabled. 

I'm not seeing the issue mentioned above.

Comment 6

[Jason Smith [:jsmith]]

QA Wanted - Can we clarify what behavior is being seen on master?

Comment 7

[Matthew Vaughan]

(In reply to Jason Smith [:jsmith] from comment #6)
> QA Wanted - Can we clarify what behavior is being seen on master?

On the 04/11/14 Master, the Grid setting will be retained when it's set from within another app (Message, Email, Wallpaper, etc.), therefore reflecting the setting after launching into the Camera app, whether directly or through another app.

The Self Timer setting will not be retained like the Grid setting is retained. Therefore it will have to be set to the desired setting each time the user enters the Camera app, whether through another app or launching the Camera directly.

- Buri Master -
Gaia  1368d716072adf308e1b435ac828f97545a045f1
Gecko d8c1b10c3a3d
BuildID 20140411040203
Version 31.0a1

Comment 8

[Jason Smith [:jsmith]]

Tiffanie - So I'm confused here - the above testing is showing that we're still seeing the issue above, but your testing is showing that none of changes are persisting. Can you try again with the latest build on 1.4?

Comment 9

[Tiffanie Shakespeare [:tif]]

It's quite possible I'm not on the correct version of something - I have no idea how to check that out. 

I just tried the latest Master out on my Nexus 4. 

I'm still seeing the same thing. The stuff I'm changing in the camera via say Messaging app doesn't seem to impact the camera settings.

It's almost like the two are independent - I change settings in camera and camera remembers those. I change settings in the Messaging app camera and it remembers those.

Since I can't repro, and it's probably something I'm not doing correctly, it might be better if I just state what would be ideal. I think camera should retain its settings and then the cameras that are launched via other apps should reflect all of those settings (HDR, flash, grid, timer, etc). Changes made during this 'mode' should be reflected back to the camera.

In the future we may want to consider having a more stripped down camera version when launching from other apps, but since we are providing the full featured camera and settings it should behave as one.

Hopefully this helps! Let me know if there's follow up q's.

Comment 10

[Mike Habicher [:mikeh] (high bugzilla latency)]

Okay, here is the behaviour I see with:
- gonk:  v184 (flame w/ 319MB)
- gecko: aurora:c4a4b04c617c
- gaia:  v2.1:778ebac47554e1c4b7e9a952d73e850f58123914

1. open Camera app
2. turn on Grid Lines
3. tap the Home button
4. open the Messages app
5. create a new message
6. tap on the paperclip to add an attachment
7. select Camera
   -- the camera UI appears with gridlines visible
8. press the X button to return to the Messages app
9. press and hold the Home button and reactivate the Camera app
   -- the camera UI still has gridlines visible

I thought that maybe this is because, even though the camera settings are persisted, the already-open-but-backgrounded Camera app isn't listening/looking for settings changes, so it comes back with its last configuration.

So as a test, after step 2 above, I closed the Camera app before following the rest of the steps. After turning the Grid Lines off in the MMS Camera, I reopened the Camera app and the Grid Lines were still enabled.

I could see this being confusing. Over to the UI team!

Comment 11

[Amy Lee [:amylee] UX]

(In reply to Mike Habicher [:mikeh] from comment #10)
> Okay, here is the behaviour I see with:
> - gonk:  v184 (flame w/ 319MB)
> - gecko: aurora:c4a4b04c617c
> - gaia:  v2.1:778ebac47554e1c4b7e9a952d73e850f58123914
> 
> 1. open Camera app
> 2. turn on Grid Lines
> 3. tap the Home button
> 4. open the Messages app
> 5. create a new message
> 6. tap on the paperclip to add an attachment
> 7. select Camera
>    -- the camera UI appears with gridlines visible
> 8. press the X button to return to the Messages app
> 9. press and hold the Home button and reactivate the Camera app
>    -- the camera UI still has gridlines visible
> 
> I thought that maybe this is because, even though the camera settings are
> persisted, the already-open-but-backgrounded Camera app isn't
> listening/looking for settings changes, so it comes back with its last
> configuration.
> 
> So as a test, after step 2 above, I closed the Camera app before following
> the rest of the steps. After turning the Grid Lines off in the MMS Camera, I
> reopened the Camera app and the Grid Lines were still enabled.
> 
> I could see this being confusing. Over to the UI team!

Flagging Katie on this since it's related to UX.

Comment 12

[katieC]

Hi Mike,

I'm covering for Tif while she's away on Maternity Leave. I see what you're talking about and after reading through the above comments, I'm just going to copy and paste from comment 9 from Tif, ideal state is: 

> I think camera should retain its settings and then the cameras that are launched via other apps should reflect all of those settings (HDR, flash, grid, timer, etc). Changes made during this 'mode' should be reflected back to the camera.

If this doesn't address the concern, I may not be understanding the question - please let me know!

Comment 13

[BMO Automation]

Firefox OS is not being worked on