Closed
Bug 993101
Opened 10 years ago
Closed 10 years ago
Offer a way to open a toolbox for the main process/shell.html
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: ochameau, Assigned: ochameau)
Details
Attachments
(1 file)
5.36 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
I think that, now that we have browser tabs in the device panel, the only reason to keep the old Connect screen is to be able to open a toolbox for the main process. Also, the connect screen is painfull to use as there isn't the adb helper, and that's the only way to get a shell.html's toolbox. I know we have the UI v2 coming, but that wouldn't be hard to implement this in the current version and would ease debugging various low level stuff in Gaia/b2g.
The Connect screen is still used with Fennec, so don't try to delete it yet! :)
Ah, never mind, I miss read. I guess you are handling the remaining use cases here.
Assignee | ||
Comment 3•10 years ago
|
||
This patch is quite conservative. It only displays the button if: - the device has the certified pref turned on in the device (i.e. tab actors for the root actors are available), - the devtools.chrome.enabled is on in Firefox, so that this button isn't displayed for regular apps developers in the simulator (May be that's too overkill?) The button is displayed in Device panel, in the header.
Attachment #8402873 -
Flags: review?(paul)
Assignee | ||
Updated•10 years ago
|
Component: Gaia → Developer Tools: App Manager
Product: Firefox OS → Firefox
Assignee | ||
Comment 4•10 years ago
|
||
Yep, that's not my plan to get rid of it. I just want to ensure we no longer need it for any usage.
Updated•10 years ago
|
Attachment #8402873 -
Flags: review?(paul) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8125c7b5b8d7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8125c7b5b8d7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•