993134 - fxa.TestAccountPickler fails on addDummyAccount if an account already exists

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Build & Test, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: testDeletePickle trace

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/461

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

How does the pull request address this bug? I'm not sure I see it. I imagine we have to deleteTestAccounts in setUp(), use numbered accounts (i.e. `TEST_USERNAME + incrementingValue++`), or similar.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #2)
> How does the pull request address this bug? I'm not sure I see it. I imagine
> we have to deleteTestAccounts in setUp(), use numbered accounts (i.e.
> `TEST_USERNAME + incrementingValue++`), or similar.

We deleteTestAccounts on tearDown, so I'm not too worried about getting into bad state; but I'll add deleting in setUp, so that we know we start clean.  Good idea.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #3)
> (In reply to Michael Comella (:mcomella) from comment #2)
> > How does the pull request address this bug? I'm not sure I see it.

We always use the same test account name(s), but now we don't fail if other accounts exist.  (And we don't try to delete other accounts.)

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8434459 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/461

Clearing until the deleteAccounts in setUp update.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8434459 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/461

Pushed patch series again, with review comments folded in.  This really did add only one line (in setUp); I don't see why it required a second pass.

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/74208e2733a4

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/74208e2733a4