993151 - [B2G][Contacts]When editing a Facebook contact, the blue highlight box does not fully cover the section that can't be edited

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Andrew Stole [:astole]]

Attachment: Screenshot

The blue highlighted section when editing a Facebook contact does not cover all of the area that cannot be edited.

Repro Steps:
1) Update a Buri to BuildID: 20140407040202
2) Open Contacts app and import a contact from Facebook that has information attached to it (ex. phone number)
3) Edit imported Facebook contact

Actual:
Blue highlight box does not fully cover section that cannot be edited

Expected:
Highlight box fully covers uneditable section

1.5 Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140407040202
Gaia: f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko: 5405d6f4e3c6
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Notes: Logcat and video will be provided shortly

Repro frequency: 100%
See attached: Screenshot, logcat

Comment 1

[Andrew Stole [:astole]]

Attachment: logcat

Comment 2

[Jason Smith [:jsmith]]

Can we get a video of the bug?

Comment 3

[Jose Manuel Cantera]

I think we need a VR for FB Data non editable. ni Vicky to get a new design and then we will reimplement.

Comment 4

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup and Spec for FB information inside edit contact

Comment 5

[Victoria Gerchinhoren [:vicky]]

(In reply to Jose M. Cantera from comment #3)
> I think we need a VR for FB Data non editable. ni Vicky to get a new design
> and then we will reimplement.

find attached the mockup and specs for implemented "locked style" of buttons when containing non-editable information comming from FB. 

Please, note that as the "x" button disappears, the value selector should grow until the max width for buttons.

Thanks

Comment 6

[Harvey]

Adding video to the URL field.

Issue can be seen from 0:05 onward.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8406140 [details] [review]
patch in github

Tried on the phone and looking perfect, as always ;)

Thanks Arnau!

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 40a374e992a2352465551bf7aa1fc2a6dbb29575

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: after_patch.png

Comment 12

[Loli (:lolimartinezcr)]

Tested and working
1.5
Hamachi
Gecko: 7db7603
Gaia: facd91d