Move runtime localization logic post document loading for pretranslation case

RESOLVED WONTFIX

Status

defect
P4
normal
RESOLVED WONTFIX
5 years ago
Last year

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Tracking

(Depends on 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

If the document is pretranslated, we currently fire l10n.js runtime logic on 'interactive'.

Based on our tests we can improve startup performance by postponing it until 'complete'.

There's one bug - bug 993189 - that currently relies on inconsistent behavior of ready() function (bug 993188).
Depends on: 993188, 993189, 914414
Assignee: nobody → gandalf
Posted patch patchSplinter Review
Attachment #8404191 - Flags: review?(stas)
Comment on attachment 8404191 [details] [diff] [review]
patch

Review of attachment 8404191 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but let's make sure we fix the dependencies first, before landing this.
Attachment #8404191 - Flags: review?(stas) → review+
Status: NEW → ASSIGNED
seems like we fail two marionette tests: https://travis-ci.org/mozilla-b2g/gaia/jobs/23162502
now only one test fails (in net_error!) https://travis-ci.org/mozilla-b2g/gaia/jobs/23312692
Blocks: 999779
Depends on: 992473
Priority: -- → P4
I just measured the gain we currently get from pretranslation on master, Keon:

           delta median
========================
browser       -15
calendar        2
camera        -37
clock          57
contacts       19
email          10
messages       65
music          24
phone          19
settings      109
usage          15
=======
         AVG:  23
Erm, sorry, the numbers are reversed. In Comment 6 the delta is from pretranslate to non-pretranslate. It means that browser firstPaints 15 ms earlier in non-pretranslate case.

Settings on the other hand firstPaint 109ms later in non-pretranslate case.
Depends on: 444165
Are we still failing the tests?  If I read the code right we already special-case the neterror page, so we should be good?

Comment 9

Last year
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.