993194 - Use more smart pointers for node info

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

Plus a few other minor cleanups.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Add a comment to nsDocument about mNodeInfoManager.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Make nsINodeInfo::mOwnerManager into an nsRefPtr.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Remove trailing whitespace from nsNodeInfoManager.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Make nsNodeInfoManager::mBindingManager into an nsRefPtr.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: part 5 - Change nsNodeInfoManager::mPrincipal into an nsCOMPtr.

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8403355 [details] [diff] [review]
part 5 - Change nsNodeInfoManager::mPrincipal into an nsCOMPtr.

https://tbpl.mozilla.org/?tree=Try&rev=a15f014376d7

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8403355 [details] [diff] [review]
part 5 - Change nsNodeInfoManager::mPrincipal into an nsCOMPtr.

Review of attachment 8403355 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsNodeInfoManager.cpp
@@ +177,5 @@
>    NS_ENSURE_TRUE(mNodeInfoHash, NS_ERROR_OUT_OF_MEMORY);
>  
>    NS_PRECONDITION(!mPrincipal,
>                    "Being inited when we already have a principal?");
> +  nsresult rv = CallCreateInstance<nsIPrincipal>("@mozilla.org/nullprincipal;1",

ITYM mPrincipal = do_CreateInstance("@mozilla.org/nullprincipal;1", &rv);

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8403354 [details] [diff] [review]
part 4 - Make nsNodeInfoManager::mBindingManager into an nsRefPtr.


>+#include "nsAutoPtr.h"                    // for nsRefPtr
Do we actually need this?
nsNodeInfoManager has non-inline ctor/dtor, so I think forward declaration would work.
Either way

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8403355 [details] [diff] [review]
part 5 - Change nsNodeInfoManager::mPrincipal into an nsCOMPtr.

r+ with the fix Ms2ger mentioned.

Comment 10

[Andrew McCreight [:mccr8]]

> Do we actually need this?
Well, I thought I'd need it because a field is nsRefPtr.  I don't think forward declaring it will work, but I can try.

Comment 11

[Andrew McCreight [:mccr8]]

I fixed the create instance thing.  I left the autoptr include because it is needed.

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=17822faead4f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60b489985023
https://hg.mozilla.org/mozilla-central/rev/0b44d3acbf1c
https://hg.mozilla.org/mozilla-central/rev/c967d0222383
https://hg.mozilla.org/mozilla-central/rev/7bf9a591c078
https://hg.mozilla.org/mozilla-central/rev/00f61ba35bf5