993227 - Integrate suggested reviewers

Status: RESOLVED WONTFIX

(MozReview Graveyard :: General, defect, P2)

Description

[Mark Côté [:mcote]]

Suggested reviewers are available from the Bugzilla API, so we should integrate it into Review Board.  It'll probably need a new widget in the UI near the "People" field.

Comment 1

[Mark Côté [:mcote]]

We shouldn't have to bother with products/components here.  Rather, there should be a Bugzilla API call that says "give me the suggested reviewers for bug X".  If that doesn't exist, it needs to. :)

Comment 2

[David Lawrence [:dkl]]

(In reply to Mark Côté ( :mcote ) from comment #1)
> We shouldn't have to bother with products/components here.  Rather, there
> should be a Bugzilla API call that says "give me the suggested reviewers for
> bug X".  If that doesn't exist, it needs to. :)

It does. Example:

https://bugzilla.mozilla.org/rest/review/suggestions/859168

[
   {
      "email" : "[e-mail]",
      "id" : 434302,
      "name" : "Eric Chou [:ericchou] [:echou]",
      "review_count" : 9
   },
   {
      "email" : "[e-mail]",
      "id" : 445298,
      "name" : "Gina Yeh [:gyeh] [:ginayeh]",
      "review_count" : 0
   }
]

Comment 3

[Mark Côté [:mcote]]

We'll be using tree metadata instead.

Comment 4

[Dave Townsend [:mossop]]

(In reply to Mark Côté [:mcote] from comment #3)
> We'll be using tree metadata instead.

Could we reconsider this? The support for defining reviewers in tree hasn't landed (bug 1137042) and I doubt bugzilla will be able to use it even when it does. It doesn't make much sense for bugzilla and mozreview to be using different sources of truth.

Comment 5

[Mark Côté [:mcote]]

We're rethinking the review-request process right now.  It might make sense to have a central service that both BMO and MozReview could use, rather than separately baking it into different places.