Closed Bug 993308 Opened 10 years ago Closed 10 years ago

Update the HTML5 video page with preload attribute on video element

Categories

(Mozilla QA Graveyard :: Infrastructure, defect)

Product:
Mozilla QA Graveyard
Component:
Infrastructure
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: danisielm, Assigned: danisielm)

References

Details

Attachments

(1 file, 1 obsolete file)

bug_993308_fix2.patch
5.11 KB, patch
andrei
: review+
andrei
: checkin+
Details | Diff | Splinter Review 
We need to update the firefox/video/test_ogv_video_60s.html page to set the attribute of the video tag to "auto".

This is needed for bug 991066
Attached patch bug_993308_fix1.patch (obsolete) — — Splinter Review 
Here is the patch for this. 
I tested it with a local html page and it fixes our problem in bug 991066.
Attachment #8403127 - Flags: review?(andrei.eftimie)
Attachment #8403127 - Flags: review?(andreea.matei)
Lets do this for all html5 compatible videos on mozqa.com, and not only that video.
Thanks for the suggestion,
Updated all the html5 video elements with the preload attribute set to "auto".
Attachment #8403127 - Attachment is obsolete: true
Attachment #8403127 - Flags: review?(andrei.eftimie)
Attachment #8403127 - Flags: review?(andreea.matei)
Attachment #8403129 - Flags: review?(andrei.eftimie)
Attachment #8403129 - Flags: review?(andreea.matei)
Comment on attachment 8403129 [details] [diff] [review]
bug_993308_fix2.patch

Review of attachment 8403129 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
I tested it and it works fine.

Landed:
http://hg.mozilla.org/qa/testcase-data/rev/a7e823c5f8c6
Attachment #8403129 - Flags: review?(andrei.eftimie)
Attachment #8403129 - Flags: review?(andreea.matei)
Attachment #8403129 - Flags: review+
Attachment #8403129 - Flags: checkin+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: