Closed Bug 993323 Opened 9 years ago Closed 9 years ago

Make nsWindowGfx::CreateIcon() use the new gfxUtils helper for format conversion

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file, 1 obsolete file)

patch
2.67 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
Currently nsWindowGfx::CreateIcon() tries to do it's own Moz2D SourceSurface format conversion. It should use the new gfxUtils helper for that since format conversion is a perf minefield (it currently steps on one of those mines).
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8403148 -
        Flags: review?(bas)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Assignee: nobody → jwatt

        Attachment #8403148 -
        Attachment is obsolete: true

        Attachment #8403148 -
        Flags: review?(bas)

        Attachment #8403149 -
        Flags: review?(bas)

        Attachment #8403149 -
        Flags: review?(bas) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/468b75c559b8
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31

          You need to log in
          before you can comment on or make changes to this bug.