Closed Bug 993364 Opened 11 years ago Closed 11 years ago

[E.me] [un-xfail] etmmanager.js

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: amirn, Assigned: amirn)

References

Details

Attachments

(1 file)

Pull Request
46 bytes, text/x-github-pull-request
amirn
: review+
Details | Review
$ LINTED_FILES=apps/homescreen/everything.me/js/etmmanager.js make hint Running jshint... apps/homescreen/everything.me/js/etmmanager.js: line 29, col 5, Do not use 'new' for side effects. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 66, col 5, Do not use 'new' for side effects. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 140, col 54, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 386, col 13, 'EvmeApp' was used before it was defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 15, col 16, 'GridItemsFactory' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 16, col 26, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 22, col 15, 'GridItemsFactory' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 24, col 5, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 25, col 5, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 25, col 37, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 29, col 9, 'MozActivity' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 50, col 20, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 51, col 5, 'Homescreen' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 66, col 9, 'MozActivity' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 83, col 5, 'LazyLoader' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 86, col 9, 'utils' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 109, col 12, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 130, col 12, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 140, col 21, 'collection' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 141, col 30, 'collection' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 151, col 19, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 173, col 12, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 198, col 16, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 207, col 23, 'Icon' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 230, col 14, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 238, col 12, 'Icon' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 246, col 19, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 247, col 18, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 281, col 24, 'MozActivity' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 295, col 24, 'MozActivity' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 316, col 16, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 325, col 16, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 334, col 16, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 346, col 14, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 347, col 15, 'Bookmark' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 381, col 14, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 387, col 3, 'Bookmark' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 390, col 1, 'extend' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 390, col 17, 'Bookmark' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 400, col 8, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 405, col 38, 'GridManager' is not defined. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 3, col 16, 'EvmeManager' is defined but never used. (ERROR) apps/homescreen/everything.me/js/etmmanager.js: line 11, col 20, 'currentWindow' is defined but never used. (ERROR) 43 errors Please consult https://github.com/mozilla-b2g/gaia/tree/master/build/jshint/README.md to get some information about how to fix jshint issues. make: *** [hint] Error 1
Blocks: 989983
Attached file Pull Request —
Make sure file passes jshint. No functional changes made.
Attachment #8403232 - Flags: review?(ran)
Assignee: nobody → amirn
landed in master: https://github.com/mozilla-b2g/gaia/commit/a98988a272a31cb3a4fae354a09bdfb393818889
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 8403232 [details] [review] Pull Request see https://bugzilla.mozilla.org/show_bug.cgi?id=993368#c3 for r+ (same PR for 2 bugs)
Attachment #8403232 - Flags: review?(ran) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: