Closed
Bug 993368
Opened 10 years ago
Closed 10 years ago
[E.me] [un-xfail] Collections.js
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amirn, Assigned: amirn)
References
Details
Attachments
(1 file)
$ LINTED_FILES=apps/homescreen/everything.me/modules/Collection/Collection.js make hint Running jshint... apps/homescreen/everything.me/modules/Collection/Collection.js: line 563, col 76, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 571, col 76, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 575, col 12, Don't make functions within a loop. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 9, col 21, Weird construction. Is 'new' necessary? (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 602, col 3, Missing '()' invoking a constructor. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 632, col 68, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 692, col 53, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 760, col 74, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 787, col 74, Expected a conditional expression and instead saw an assignment. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 791, col 10, Don't make functions within a loop. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 872, col 28, Weird construction. Is 'new' necessary? (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 913, col 3, Missing '()' invoking a constructor. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 9, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 43, col 18, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 44, col 17, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 45, col 17, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 46, col 17, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 60, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 121, col 23, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 138, col 13, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 140, col 13, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 173, col 42, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 177, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 191, col 7, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 194, col 11, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 205, col 30, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 208, col 19, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 210, col 22, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 215, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 235, col 33, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 246, col 35, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 263, col 33, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 280, col 11, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 307, col 20, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 331, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 336, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 343, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 349, col 25, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 391, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 408, col 11, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 414, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 419, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 444, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 456, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 552, col 27, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 560, col 21, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 561, col 29, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 569, col 29, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 572, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 584, col 28, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 592, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 609, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 639, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 642, col 31, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 648, col 9, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 649, col 15, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 661, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 662, col 48, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 663, col 27, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 667, col 28, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 669, col 26, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 670, col 13, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 684, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 689, col 24, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 707, col 11, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 725, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 731, col 5, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 740, col 23, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 742, col 19, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 751, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 759, col 27, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 761, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 772, col 30, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 776, col 17, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 781, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 786, col 27, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 788, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 803, col 30, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 819, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 828, col 7, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 843, col 7, 'EvmeManager' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 848, col 17, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 850, col 24, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 851, col 24, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 853, col 39, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 861, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 872, col 3, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 882, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 885, col 42, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 888, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 900, col 44, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 901, col 7, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 903, col 30, 'Evme' is not defined. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 172, col 15, 'apps' is defined but never used. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 667, col 25, 'installedIcons' is defined but never used. (ERROR) apps/homescreen/everything.me/modules/Collection/Collection.js: line 873, col 13, 'NAME' is defined but never used. (ERROR) 96 errors Please consult https://github.com/mozilla-b2g/gaia/tree/master/build/jshint/README.md to get some information about how to fix jshint issues. make: *** [hint] Error 1
|
Assignee | |
Comment 1•10 years ago
|
||
Make sure file passes jshint. No functional changes made.
Attachment #8403233 -
Flags: review?(ran)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → amirn
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8403233 [details] [review] Pull Request LGTM
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8403233 [details] [review] Pull Request LGTM
Attachment #8403233 -
Flags: review?(ran) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
landed in master: https://github.com/mozilla-b2g/gaia/commit/a98988a272a31cb3a4fae354a09bdfb393818889
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•