993406 - [Contacts][unit test] Follow up 909201: Add unit test to search view when a contacts change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We didn't add unit test in bug 909201 for an easy way of a contributor to start helping with the project, but we should have them.

Take a look to patch proposed in bug 955972 to have an idea of how to do this.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 18176

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8404693 [details] [review]
Pointer to PR 18176

Overall looks good, but lets try to kill that |setTimeout()| if we can.  I think if we pass the callback through to the search update code we can avoid it.  What do you think?

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

I though that, actually if you take a look to the code I already modified the order where the search update and the callback are called.

The problem is |updateSearchList| is asynchronous as well.

But definitely will explore that rather than left there the setTimeout (blame on me for even trying ;))

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8404693 [details] [review]
Pointer to PR 18176

What about now?

;)

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8404693 [details] [review]
Pointer to PR 18176

r=me with fixes noted on github and green travis.  TBPL try build for bonus points. :-)  Looks like travis is running way behind today.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Thanks!

Comments addressed, will wait for travis green before merging.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/b58048b65305911fddfe386f75b49f831ba819fc