Closed Bug 993430 Opened 7 years ago Closed 7 years ago

[VDR][FTE] Apply Buttons and Input areas [BB]

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: arnau, Assigned: arnau)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken )

Attachments

(1 file)

No description provided.
Assignee: nobody → arnau
Blocks: 965889
Depends on: 967843
Whiteboard: ux-tracking, visual design, visual-tracking, bokken
Attached file patch in github
Attachment #8403988 - Flags: review?(borja.bugzilla)
Attachment #8403988 - Flags: review?(felash)
Related is bug 926385, a contributor is working on this.

TLDR: the root.css in the Messages app is overriding some building blocks
Mmm sorry bug 926385 is about Messages and I see this bug is about the FTU :)

Borja, I'm not a FTU peer, do you really want that I look at it?
Comment on attachment 8403988 [details] [review]
patch in github

My fault! Removing the r? to Julien and taking a look right now.
Attachment #8403988 - Flags: review?(felash)
After testing the patch the new UI looks great, but there is an issue with the new <li> structure related with the top-border. STR:
- Go to the step 'Wifi' in FTU
- Choose a network with WPA-PSK

Expected:
Password field is shown without any border in the top or bottom.

Currently:
Weird top-border appears collapsing with the progress bar of the app. Please fix this, I'll test again and for me it's fine!
Comment on attachment 8403988 [details] [review]
patch in github

Ask me again to review this when ready. Thanks!
Attachment #8403988 - Flags: review?(borja.bugzilla) → feedback+
Attachment #8403988 - Flags: review?(borja.bugzilla)
Comment on attachment 8403988 [details] [review]
patch in github

Please wait for Travis to be green before merging:
https://travis-ci.org/mozilla-b2g/gaia/builds/22703743

Thanks!
Attachment #8403988 - Flags: review?(borja.bugzilla) → review+
Merged: 8c4a2fd665f85fadad4a5ccfb8495298fa4923b1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in before you can comment on or make changes to this bug.