993430 - [VDR][FTE] Apply Buttons and Input areas [BB]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Julien Wajsberg [:julienw]]

Related is bug 926385, a contributor is working on this.

TLDR: the root.css in the Messages app is overriding some building blocks

Comment 3

[Julien Wajsberg [:julienw]]

Mmm sorry bug 926385 is about Messages and I see this bug is about the FTU :)

Borja, I'm not a FTU peer, do you really want that I look at it?

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8403988 [details] [review]
patch in github

My fault! Removing the r? to Julien and taking a look right now.

Comment 5

[Borja Salguero [:borjasalguero]]

After testing the patch the new UI looks great, but there is an issue with the new <li> structure related with the top-border. STR:
- Go to the step 'Wifi' in FTU
- Choose a network with WPA-PSK

Expected:
Password field is shown without any border in the top or bottom.

Currently:
Weird top-border appears collapsing with the progress bar of the app. Please fix this, I'll test again and for me it's fine!

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 8403988 [details] [review]
patch in github

Ask me again to review this when ready. Thanks!

Comment 7

[Borja Salguero [:borjasalguero]]

Comment on attachment 8403988 [details] [review]
patch in github

Please wait for Travis to be green before merging:
https://travis-ci.org/mozilla-b2g/gaia/builds/22703743

Thanks!

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 8c4a2fd665f85fadad4a5ccfb8495298fa4923b1