993467 - mailnews/base/src/nsMessengerUnixIntegration.cpp:26: ... fatal error: 'pixman.h' file not found (--enable-system-pixman)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jan Beich]

Bug 941595 fixed --enable-system-pixman in m-c but there were no corresponding commit in c-c, or it wasn't backported to seamonkey-2.26.

In file included from mailnews/base/src/nsMessengerUnixIntegration.cpp..:26:
In file included from mozilla/dist/include/nsIWidget.h:21:
In file included from mozilla/dist/include/mozilla/layers/LayersTypes.h:11:
In file included from mozilla/dist/include/nsRegion.h:23:
mozilla/dist/system_wrappers/pixman.h:3:15: fatal error: 'pixman.h' file not found
#include_next <pixman.h>
              ^
1 error generated.

Comment 1

[Jan Beich]

Attachment: fix

Comment 2

[Jan Beich]

Comment on attachment 8404488 [details] [diff] [review]
fix

[Approval Request Comment]
Regression caused by (bug #): bug 845874 regression
User impact if declined: --with-system-pixman and --with-system-cairo broken build
Testing completed (on m-c, etc.): soon
Risk to taking this patch (and alternatives if risky): Very low: affects only build and MOZ_PIXMAN_CFLAGS are empty on TBPL.
String changes made by this patch:

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8404488 [details] [diff] [review]
fix

Looks good, thanks. I'll approve this once its landed on central.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/c27f7537bc1b

Comment 5

[Jan Beich]

Not specific to FreeBSD, some other downstream users are also affected: ArchLinux (pixman), Gentoo (cairo, optionally), Mageia (cairo), PkgSrc (cairo) and, probably, more.

Comment 6

[Philip Chee]

Comment on attachment 8404488 [details] [diff] [review]
fix

For some reason this fell between the cracks. Apologies all.