993475 - Basic compositor doesn't support masks on color layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Lord [:cwiiis]]

As stated in the bug title. Patch incoming.

Comment 1

[Chris Lord [:cwiiis]]

hmm, I said patch incoming, but my patch doesn't work completely yet... Will attach the WIP.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Support masks on color layers in BasicCompositor (WIP)

Comment 3

[Chris Lord [:cwiiis]]

Attachment: Support masks on color layers in BasicCompositor

Took me an embarrassingly long time to work this out :p

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8403986 [details] [diff] [review]
Support masks on color layers in BasicCompositor

Review of attachment 8403986 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/basic/BasicCompositor.cpp
@@ +328,5 @@
> +      } else {
> +        dest->FillRect(aRect,
> +                       ColorPattern(effectSolidColor->mColor),
> +                       DrawOptions(aOpacity));
> +      }

Looks good, bonus points if you can share the code between this and FillRectWithMask (in BasicLayersImpl.cpp).

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Consolidate masking code in BasicCompositor and BasicLayersImpl

I like the idea of bonus points, and hadn't seen BasicLayersImpl... Open to ideas for doing this in a less verbose way, but I couldn't quickly think of anything.

Comment 6

[Chris Lord [:cwiiis]]

Pushed to inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f419e249a07
https://hg.mozilla.org/integration/mozilla-inbound/rev/16803b53b8a5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f419e249a07
https://hg.mozilla.org/mozilla-central/rev/16803b53b8a5