Closed Bug 993581 Opened 10 years ago Closed 10 years ago

use an empty directory tiles data source pref

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox31 --- fixed

People

(Reporter: clarkbw, Assigned: Mardak)

References

(
URL
)

Details

(Whiteboard: p=2 s=it-31c-30a-29b.2 [qa-])

Attachments

(1 file)

v1
1.03 KB, patch
adw
: review+
Details | Diff | Splinter Review 
For the short term can we change the directory tiles data source pref 'browser.newtabpage.directorySource' to point to an empty data set?

We aren't ready to turn this on just yet.  I'd expect that we would revert this pref later once we are ready to go live with the tiles data we have landed. bug 991853 is updating the current Tiles data.
Blocks: 990713, tiles-dev
Depends on: 991853
No longer depends on: 991853
Attached patch v1 — — Splinter Review 

        Attachment #8403604 -
        Flags: review?(adw)

    
    

    
  
adw, the reason for changing the pref instead of removing adding the directoryLinksProvider is so that we can still test the functionality by setting the local pref back to chrome://global/content/directoryLinks.json

    
  

        Attachment #8403604 -
        Flags: review?(adw) → review+

    
  
Component: Tabbed Browser → General

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ddd7db33608b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31

    
    

    
  
Hi Ed, can you provide a point value for this bug.
Flags: needinfo?(edilee)
Flags: firefox-backlog+
Whiteboard: p=0 s=it-31c-30a-29b.2

    
  
Flags: needinfo?(edilee)
Whiteboard: p=0 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2

    
    

    
  
Hi Anthony, can you review if this resolved bug requires further verification.  Thanks.
Flags: needinfo?(anthony.s.hughes)

    
    

    
  
I don't think this is something QA needs to test. We'll want to test the pref is working when we want to start using it, but that's a separate issue.

          status-firefox31:
          --- → fixed
Flags: needinfo?(anthony.s.hughes)
Whiteboard: p=2 s=it-31c-30a-29b.2 → p=2 s=it-31c-30a-29b.2 [qa-]
Status: RESOLVED → VERIFIED
See Also:  → 1039881

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: