9936 - xul has confusing references to "Advanced" ("More Attribs")

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kathleen :Brade]

The Link dialog has referenced to a titledbutton with id="Advanced" which is
intended to be the "More Attributes..." (previously known as "Extra HTML").  The
id and onclick handler should be renamed.

The HRule and NamedAnchor dialogs also have such titledbuttons which should have
their ids and onclick handlers renamed.

Comment 1

[Charles Manske]

I'm sorry about the IDs -- I didn't realize they were the source of the
confusion between "Advanced" and "More Attributes"
We need both buttons for those dialogs that will have an "Advanced" expanded
section: Image, Table/Cell, and Link dialogs, although I'm not sure if the
link dialog really needs it.
We need to resolve where to put each in the dialogs.

Comment 2

[Charles Manske]

We have decided to use "Advanced Edit..." instead of "More Attributes..." for
the button, and although I changed the IDs and onclick handler names, they
should be changed to be consistent with the action.
We will use "More" and "Fewer" as the label for the button that
expands/contracts a dialog to show/hide controls.
Kathy: what would you suggest for the name of that button and onclick handler?
How about "MoreOrLess" for the ID and "onMoreOrLess" for the onclick?

Comment 3

[Kathleen :Brade]

that's fine with me

Comment 4

[sujay]

verified in 7/28 build.

Comment 5

[Kathleen :Brade]

The link dialog still has an entity declared as "Advanced" when it should be
"More" (and another one declared as "Fewer")