993746 - name of @keyframes rules is not properly escaped

Status: ASSIGNED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: test case

When read from DOM API, name of @keyframes rules is not escaped.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8403640 [details] [diff] [review]
patch

The GetCssText change seems correct, but I think the GetName change is wrong.  Why would we do CSS escaping there?

Also, it seems worth adding a test for both GetCssText and GetName; it could go in layout/style/test/test_keyframes_rules.html

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-7) from comment #2)
> Comment on attachment 8403640 [details] [diff] [review]
> patch
> 
> The GetCssText change seems correct, but I think the GetName change is
> wrong.  Why would we do CSS escaping there?

Hmm, it seems you are right, since SetName accepts arbitrary string. There is some subtle difference in setter behavior of name attribute between CSS Animation and Counter Style spec. Maybe one of them should be fixed to keep coherence.

> Also, it seems worth adding a test for both GetCssText and GetName; it could
> go in layout/style/test/test_keyframes_rules.html

That's reasonable.