Closed Bug 993834 Opened 6 years ago Closed 6 years ago

[NetworkStats API] missing the store_name parameter when calling dbNewTxn in function getAvailableServiceTypes

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S1 (9may)

People

(Reporter: vicamo, Assigned: johnshih.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #922926 comment 98 +++

|this.dbNewTxn| has prototype |function dbNewTxn(store_name, txn_type, callback, txnCb)|.  In function getAvailableServiceTypes, the first parameter "store_name" is missing.
Nominate for 1.3T? because bug 922926 is a 1.3T+.
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #1)
> Nominate for 1.3T? because bug 922926 is a 1.3T+.

The function is not used currently so it won't block any features in 1.3 & 1.3T.

Anyway, I'll fix it.
Assignee: nobody → jshih
blocking-b2g: 1.3T? → ---
remove tracing flags also.
Attachment #8404441 - Flags: review?(gene.lian)
Comment on attachment 8404441 [details] [diff] [review]
Bug 993834 - Fix error in NetworkStatsDB & Test cases. r=gene

Review of attachment 8404441 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/src/NetworkStatsDB.jsm
@@ +309,5 @@
>              }
>            }, this);
>          };
> +      } else if (currVersion == 7) {
> +        // Create indeox for 'ServiceType' in order to make it retrievable.

s/indeox/index/

::: dom/network/tests/test_networkstats_basics.html
@@ +291,5 @@
> +    req = netStats.getAvailableServiceTypes();
> +    req.onsuccess = function () {
> +      ok(true, "getAvailableServiceTypes request ok");
> +      ok(Array.isArray(req.result) && req.result.length > 0,
> +         "getAvailableServiceTypes returns an array not empty");

s/not empty/which is not empty/
Attachment #8404441 - Flags: review?(gene.lian) → review+
patch update
Attachment #8404441 - Attachment is obsolete: true
Attachment #8405139 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9cea60d68e3d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
You need to log in before you can comment on or make changes to this bug.