993834 - [NetworkStats API] missing the store_name parameter when calling dbNewTxn in function getAvailableServiceTypes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #922926 comment 98 +++

|this.dbNewTxn| has prototype |function dbNewTxn(store_name, txn_type, callback, txnCb)|.  In function getAvailableServiceTypes, the first parameter "store_name" is missing.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Nominate for 1.3T? because bug 922926 is a 1.3T+.

Comment 2

[John Shih]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #1)
> Nominate for 1.3T? because bug 922926 is a 1.3T+.

The function is not used currently so it won't block any features in 1.3 & 1.3T.

Anyway, I'll fix it.

Comment 3

[John Shih]

remove tracing flags also.

Comment 4

[John Shih]

Attachment: Bug 993834 - Fix error in NetworkStatsDB & Test cases. r=gene

Comment 5

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8404441 [details] [diff] [review]
Bug 993834 - Fix error in NetworkStatsDB & Test cases. r=gene

Review of attachment 8404441 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/src/NetworkStatsDB.jsm
@@ +309,5 @@
>              }
>            }, this);
>          };
> +      } else if (currVersion == 7) {
> +        // Create indeox for 'ServiceType' in order to make it retrievable.

s/indeox/index/

::: dom/network/tests/test_networkstats_basics.html
@@ +291,5 @@
> +    req = netStats.getAvailableServiceTypes();
> +    req.onsuccess = function () {
> +      ok(true, "getAvailableServiceTypes request ok");
> +      ok(Array.isArray(req.result) && req.result.length > 0,
> +         "getAvailableServiceTypes returns an array not empty");

s/not empty/which is not empty/

Comment 6

[John Shih]

Attachment: Bug 993834 - Fix error in NetworkStatsDB & Test cases. r=gene

patch update

Comment 7

[John Shih]

try: https://tbpl.mozilla.org/?tree=Try&rev=030c165183d8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9cea60d68e3d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9cea60d68e3d