Closed
Bug 993846
Opened 10 years ago
Closed 10 years ago
No error message when adding an invalid Security Device
Categories
(Core Graveyard :: Security: UI, defect)
Core Graveyard
Security: UI
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
If you try to add an invalid DLL in the Preferences->Advanced->Security Devices dialog, you don't get an error and the dialog does not close.
The error on the console is:
document.getElementById("pipnss_bundle") is null. Line 42 in device_manager.js.
|
Assignee | |
Comment 1•10 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/load_device.xul has pippki_bundle but not pipnss_bundle. See: http://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/device_manager.xul
|
|
Assignee | |
Comment 2•10 years ago
|
||
Probably caused by bug 445371
|
|
Assignee | |
Comment 3•10 years ago
|
||
Add missing stringbundle
Attachment #8403760 -
Flags: review?(kaie)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8403760 [details] [diff] [review] Add missing stringbundle r=kaie
Attachment #8403760 -
Flags: review?(kaie) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5115eb8de822
Assignee: nobody → mozilla
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5115eb8de822
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•10 years ago
|
QA Whiteboard: [good first verify]
|
||
Comment 7•10 years ago
|
||
As Mike said "no error message with unclosed dialog box " is verified. [bugday-20140618] status-> verified branch->Firefox 30
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•