993959 - Dotted square appears on popup notification anchor icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Bogdan Maris, Desktop QA]

Reproducible on try build http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-e487810349d2/ (BuildID: 20140407110118)

Steps to reproduce:
1. Start Firefox.
2. Open a Private window. (This is for windows only, if using Linux skip this step)
3. Load https://www.google.fr/
4. Hit the Translation icon.

Expected results: No visual issue is present.

Actual results: A dotted square appears on the icon when retrieving the infobar.

Notes:
1. This happens only in Private Window on Windows 7, XP and Windows 8.1 but not on Windows 8.1 on a Surface Pro 2.
2. This happens also in normal mode on Ubuntu.
3. I did not encountered this issues on Mac OS X 10.9.2 but as can be seen from the attached .gif from URL, the dotted area moves to browsed area if the infobar is closed.

Comment 1

[Florian Quèze [:florian]]

Mass move of translation bugs to the new Translation component.

Comment 2

[Dão Gottwald [:dao]]

The dotted focus outline is common to all icons in that area. It's an accessibility feature.

Comment 3

[Florian Quèze [:florian]]

(In reply to Dão Gottwald [:dao] from comment #2)
> The dotted focus outline is common to all icons in that area. It's an
> accessibility feature.

What do you mean by "It's an accessibility feature."

Isn't this outline only expected to be displayed when the element is focused using the keyboard? It seems wrong to have this outline appear only after the user has clicked the icon (and the icon is no longer useful).

Comment 4

[Dão Gottwald [:dao]]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to Dão Gottwald [:dao] from comment #2)
> > The dotted focus outline is common to all icons in that area. It's an
> > accessibility feature.
> 
> What do you mean by "It's an accessibility feature."
>  
> Isn't this outline only expected to be displayed when the element is focused
> using the keyboard? It seems wrong to have this outline appear only after
> the user has clicked the icon (and the icon is no longer useful).

No. You need to use the keyboard to enable focus rings, but once you've done that they'll appear wherever focus moves regardless of how it moves. See bug 418521.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

So what's the desired behavior now? What exactly is wrong and needs to be fixed, I can't tell from the previous comments. Dão or Florian, can you please help me figure out?

Comment 6

[Florian Quèze [:florian]]

Not completely sure. I used to think that it was wrong to keep the focus on the icon because it's useless once clicked... but now that we are making the icon toggle the infobar (bug 1008195) keeping the focus on it makes sense.

So I would say that what needs to be fixed here is that the focus ring on the icon is very ugly on Windows (displayed above the icon, rather than around it).

Comment 7

[Dão Gottwald [:dao]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> So I would say that what needs to be fixed here is that the focus ring on
> the icon is very ugly on Windows (displayed above the icon, rather than
> around it).

The code for that is here:

http://hg.mozilla.org/mozilla-central/annotate/b5b35ec88db8/browser/themes/windows/browser.css#l1319

http://hg.mozilla.org/mozilla-central/annotate/eb2a6f7785a2/browser/themes/linux/browser.css#l1040

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-993959-Fix-focus-outline-for-.notification-ancho.patch

The focus outline seems broken on Windows only, the Linux theme doesn't specify an offset. This fixes the outline for the other notification icons (like plugins etc.) on Windows as well.

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/7d55018fe80a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7d55018fe80a

Comment 12

[Bogdan Maris, Desktop QA]

Verified as fixed on Windows 8 32bit, Ubuntu 13.04 64bit and Mac OS X 10.9.2 using Nightly rev 7d55018fe80a.